[Done 1.4.0][CODE] Number of posts correction with RemoveThread.php

[sylvester]

Code Select Expand

<id>
Number of posts correction with RemoveThread.php
</id>
<version>
1
</version>

<mod info>
If you remove a topic, the number of posts of a member won't decrease. With this mod, it will :)
So, this is a BUGFIX :)
</mod info>

<edit file>
Sources/RemoveThread.php
</edit file>

<search for>
   $row = mysql_fetch_array($request);
</search for>

<add after>
   $request2 = mysql_query("SELECT ID_MEMBER FROM {$db_prefix}messages WHERE ID_TOPIC='$threadid'");
</add after>

<search for>
$request = mysql_query("DELETE FROM {$db_prefix}log_topics WHERE ID_TOPIC=$threadid");
</search for>

<add after>

   while($temp = mysql_fetch_row($request2)) {
      if($temp[0] != '-1') {
         $request = mysql_query("UPDATE {$db_prefix}members SET posts=posts-1 WHERE ID_MEMBER='$temp[0]'");
      }
   }
</add after>


[Chris Cromer]

It is supposed to that way, this isn't a bug fix.

[sylvester]

It is supposed to that way, this isn't a bug fix.

There is no query in RemoveThread.php for {$db_prefix}members, so it can't decrease the number of posts
AND....i've tested it out before i made this 'bugfix', otherwise i didn't make this 'bugfix'

RemoveThread.php

Code Select Expand

<?php
/*****************************************************************************/
/* RemoveThread.php                                                          */
/*****************************************************************************/
/* YaBB: Yet another Bulletin Board                                          */
/* Open-Source Project started by Zef Hemel ([email protected])                 */
/* Software Version: YaBB SE                                                 */
/* ========================================================================= */
/* Software Distributed by:    http://www.yabb.info                          */
/* Support, News, Updates at:  http://www.yabb.info/community                */
/*                             http://yabb.xnull.com/community               */
/* ========================================================================= */
/* Copyright (c) 2001-2002 Lewis Media - All Rights Reserved                 */
/* Software by: The YaBB Development Team                                    */
/*****************************************************************************/
/* This program is free software; you can redistribute it and/or modify it   */
/* under the terms of the GNU General Public License as published by the     */
/* Free Software Foundation; either version 2 of the License, or (at your    */
/* option) any later version.                                                */
/*                                                                           */
/* This program is distributed in the hope that it will be useful, but       */
/* WITHOUT ANY WARRANTY; without even the implied warranty of                */
/* MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE.  See the GNU General */
/* Public License for more details.                                          */
/*                                                                           */
/* The GNU GPL can be found in gpl.txt in this directory                     */
/*****************************************************************************/

$removethreadplver="YaBB SE 1.4.0";

function RemoveThread2 () {
   global $username,$moderators,$settings,$modSettings,$txt,$cgi,$yySetLocation,$currentboard,$cgi,$threadid,$db_prefix;
   if (!(in_array($username,$moderators) &#124;&#124; $settings[7]=='Administrator' &#124;&#124; $settings[7]=='Global Moderator'))
      fatal_error("$txt[73]");
  
    //Lines 38-45 all there to delete attachments on thread deletion - Jeff
    $request = mysql_query("SELECT attachmentFilename FROM {$db_prefix}messages WHERE (ID_TOPIC=$threadid AND attachmentFilename<>NULL)");

    if (mysql_num_rows($request)>0){
       while($row = mysql_fetch_array($request)){
        unlink($modSettings['attachmentUploadDir'] . "/" . $row['attachmentFilename']);
      }
   }

   $request = mysql_query("SELECT ID_BOARD,numReplies,ID_POLL FROM {$db_prefix}topics WHERE ID_TOPIC=$threadid");
   $row = mysql_fetch_array($request);
   $request = mysql_query("DELETE FROM {$db_prefix}polls WHERE ID_POLL='$row[ID_POLL]' LIMIT 1");
   $row['numReplies']++;
   $request = mysql_query("UPDATE {$db_prefix}boards SET numTopics=numTopics-1,numPosts=numPosts-$row[numReplies] WHERE ID_BOARD=$row[ID_BOARD]");
   $request = mysql_query("DELETE FROM {$db_prefix}topics WHERE ID_TOPIC=$threadid");
   $request = mysql_query("DELETE FROM {$db_prefix}messages WHERE ID_TOPIC=$threadid");
   $request = mysql_query("DELETE FROM {$db_prefix}calendar WHERE id_topic=$threadid");
   $request = mysql_query("DELETE FROM {$db_prefix}log_topics WHERE ID_TOPIC=$threadid");

   $yySetLocation = "$cgi";
   redirectexit();
}

?>


[Chris Cromer]

There is no query in RemoveThread.php for {$db_prefix}members, so it can't decrease the number of posts  

Well I thought that you made it do that, from the sound of the topic and what you wrote, sorry about the missunderstanding.

[Stud Muffin]

Is this still needed for 1.4.1 ?

[sylvester]

Is this still needed for 1.4.1 ?

yes

[Jeff Lewis]

It is NOT a bug fix. RemoveThreads was designed this way so peoples post counts are messed over when cleaning up old posts.

[sylvester]

It is NOT a bug fix. RemoveThreads was designed this way so peoples post counts are messed over when cleaning up old posts.

Oh, sorry Jeff

[Zayexi Hayati]

So is there a way to not reduce the number of posts a member has when deleting a post?

[[Unknown]]

If you delete a thread, it decreases the post count over members with this mod.  Otherwise it does not.

Deleting a single post, however, always decreases the post count.  If this is not the desired effect, you can edit their profile and raise it.... but... normally you only delete a single post because it should not have been posted.

Could someone split this and move to Administration Help?

-[Unknown]

[Zayexi Hayati]

Actually I tested it and when I deleted a single post it takes one away from the post count

I then tried it on a whole topic and it also reduced the number of posts for the members who had posted.

I am using Version 1.5.1 So was it something that was added to the new version?

[Webby]

Ok, whenever we decide to "clean up" our board, our GM's will remove old topics and threads.

The result is, that people see their postcount decreasing by xx posts.

I think this shouldn't happen, because they actually DID post the topics.

So wouldn't it be better to let the postcount be what it was before deleting the topic / thread ?

Also : where can I change the code to "fix" this on my board ?

I use v1.5.1Rc38

Thanx in advance

[[Unknown]]

To disable this, remove the following lines from RemoveThreads.php:

Code Select Expand

   while ($temp = mysql_fetch_row($request2))
      if ($temp[0] != -1)
         $request = mysql_query("
            UPDATE {$db_prefix}members
            SET posts=posts-1
            WHERE ID_MEMBER='$temp[0]';") or database_error(__FILE__, __LINE__);


And also (this isn't important...) these:

Code Select Expand

   $request2 = mysql_query("
      SELECT ID_MEMBER
      FROM {$db_prefix}messages
      WHERE ID_TOPIC='$threadid';") or database_error(__FILE__, __LINE__);

Question:  Which do people prefer?  I always thought it was still the old way - and liked the old way too.

-[Unknown]

[Webby]

Thanx.

I prefer this way :

When I post 10 topics, and an admin or GM decides to delete 2, I still have posted 10 topics and not 8.

Ok, when somebody wants to "score" topics, you can always decide to decrease the postcount of this member to show him a lesson, but this is my opinion (and also of my members).

[David]

I think if you delete an individual post the members count should go down.  If you delete an entire thread, it should not decrease.  If you remove old topics it should not decrease.  If you delete a board it should not decrease.