[Done 1.4.0/1.4.1] Attachment Download Counter

[Big P]

Grand then

BTW, I just wrote a mod that puts the clip.gif in the messageindex (beside the subject) if there is an attachment in the first post. I wrote it as a request. I was wondering should I put it in this mod, or should I release it seperately, or does anyone want this?

[Rpg Cyco]

I uninstalled the mod for the same problem, only admins could view attachments...

l8ter

Rpg Cyco

[Mach8]

I think you should release it as a separate mod (or an extension to this mod) as it gives the forum administrator more installation options. They might want the download counter, but not the message index icon. Or vice-versa.

[Big P]

I think you should release it as a separate mod (or an extension to this mod) as it gives the forum administrator more installation options. They might want the download counter, but not the message index icon. Or vice-versa.

Yeah I think so, but I'm not sure if its really wanted though. I'm putting it on my board, I saw vB has it too  

I uninstalled the mod for the same problem, only admins could view attachments...

l8ter

Rpg Cyco

See what Mach8 said? Open ManageAttachment.php. As I've already said, my mod doesn't even use a is_admin(); statement. Hmm..

[Mach8]

Okay, the ManageAttachments.php does have it in by default, I've just checked. Here's the fix (not sure if you want to include it or not):

Find:

Code Select Expand

is_admin();

function ManageAttachments (){
And replace with:

Code Select Expand

function ManageAttachments (){

is_admin();
The download counter should work then

It's because the admin check was being applied to the whole of the file, including your Download() function, so by incorporating it only into the admin function your download function is unaffected.

[Mach8]

There's more:

Find:

Code Select Expand

function RemoveAttachmentByAge()
{
Replace with:

Code Select Expand

function RemoveAttachmentByAge()
{
is_admin();
Find:

Code Select Expand

function RemoveAttachmentBySize()
{
Replace with:

Code Select Expand

function RemoveAttachmentBySize()
{
is_admin();
Find:

Code Select Expand

function RemoveAttachment()
{
Replace with:

Code Select Expand

function RemoveAttachment()
{
is_admin();
Find:

Code Select Expand

function RemoveAllAttachments()
{
Replace with:

Code Select Expand

function RemoveAllAttachments()
{
is_admin();

[Big P]

actually that was probably done deliberately as the whole file was meant to for admins only..
So technically its not a bug, but I didn't notice it  
Do the fixes Mach8 put up there to get it to work. I could just add my function too another part, or make its own file. What do you think is best?

[Mach8]

Yeah, that makes sense come to think of it.

Not sure what everyone else thinks, but I'd put it in its own separate file, I like modular programming
It's also something less for people to edit.

[Big P]

The mod has been repackaged and is now ready for download. The download function is in a seperate file. Let me know how you get on please.  

[Stud Muffin]

Got this to install ok on 1.4.1 after altering a couple of steps in the mod file as i got a couple of "string not found".  I think this was just as the format had changed slightly in the files for 1.4.1.  

Cool mods Big P  

[Surfy]

i can attach Files, but they are not linked correctly :-(

[Big P]

ahh crud, I missed this thread before. I'll fix up the mod for the 1.4.1 release, didn't know it wasn't compatible.
Surfy, which version of yabb are you using? 1.4.0? as thjis mod was designed for that version. I'll try get this working by tonight and I'll have the link up.

[Stud Muffin]

ahh crud, I missed this thread before. I'll fix up the mod for the 1.4.1 release, didn't know it wasn't compatible.
Surfy, which version of yabb are you using? 1.4.0? as thjis mod was designed for that version. I'll try get this working by tonight and I'll have the link up.

Its not completely compatible as i had to change a couple of search lines in it.

[Big P]

Only 3/4 steps needed changing. The mod file is ready for download and includes both 1.4.0 and 1.4.1 compatible versions.   If you have a problem let me know, but it does work for me anyway.

[3DGuy]

Can someone make this compatible with YaBBSE 1.5.1? I really need this mod.. its NEAT