Mod to fix Quote redirects

[gandolphxx]

I have a very active forum and attentive moderators - we move threads where they belong and split/merge to maintain continuity - this leads to quote references having the incorrect board id. In reality the board id is never needed anyway since the messages are unique - seems like a leftover from YaBB.

The following patch in Display.php will fix the errant quote problem with only a small overhead incurred for quote redirects that fail the current board test - quite negligible and far better than being told that the topic doesn't exist when indeed it does.

The loopback ensures that security is maintained and the global variable should prevent an infinite loop.

Code Select Expand


<search for>
  global $sourcedir, $sc, $prev_next;
</search for>

<add after>
  global $Gxx_display_redirect;
</add after>

<search for>
  if (mysql_num_rows($request) == 0)
     fatal_error($txt[472]);
</search for>

<replace>
  if (mysql_num_rows($request) == 0)
  {
     $request = mysql_query("
     SELECT ID_BOARD FROM {$db_prefix}topics
     WHERE ID_TOPIC = $viewnum") or database_error(__FILE__, __LINE__);
     if (mysql_num_rows($request) == 0 || $Gxx_display_redirect == 1)
     {
        fatal_error($txt[472]);
     }
     else
     {
        $row = mysql_fetch_row($request);
        $currentboard = $row[0];
        $Gxx_display_redirect = 1;
        Display();
     }
  }
</replace>


My contribution to happy forum users.

[Chris Cromer]

Wouldn't it be simpiler to just remove the part of the query that says WHERE (board_id='$board')

I still can't figure out why they put it there in the first place because there can't be a post with the same id on 2 different boards. :-/

So in otherwords using $board does nothing but clutter up the code for displaying topics. :-/

Anyway, great work I hate it when you can't find the topic you are looking for because it was moved.

[edit]I am not sure about this... but they "might" have done this so that they didn't have to code permission in display topic for the boards and categories... not positive on this... but it just hit me just now... after I had posted this. [/edit]

[gandolphxx]

In general I agree that the board id is useless, but in my case I am utilizing the excellent "allowed  users" mod extensively and need it for sub forum access in the near future - that is why I did the recursive call - to force permission checking - sometimes threads get moved to restricted boards and this trick catches that.

[[Unknown]]

Yeah, that's why the next version doesn't include the $board in every URL anymore ... in fact, $cgi is *gone*.

-[Unknown]