[Done 1.4.1][Code]Enhanced IM Box V2

[Wiziwig]

This changes the IM buttons to align along the bottom of both in and out box screens, it also adds a report to webmaster in the inbox view. Qoute features work this time and all pertainent functional changes have succesfully passed inhouse tests.

1. Backup your system setups (shouldn't you always?)

2. Copy/transfer over images in the yabbimages directory if needed.

3. Apply mod manually or with boardmod

Enjoy!

Graphic:

http://www.the-meeting-place.com/members/uploads/enhim.jpg

Archive:
http://www.the-meeting-place.com/members/uploads/ENH-IM-Box.zip

[Daniel D.]

Code Select Expand

Parse error: parse error, unexpected '<' in E:\wampp2c\htdocs\yabb14\Sources\InstantMessage.php on line 265

Fatal error: Call to undefined function: imindex() in E:\wampp2c\htdocs\yabb14\index.php on line 232
Line 265:

Code Select Expand

<a href="javascript:DoConfirm('$txt[154]?','$cgi&action=imremove&caller=1&id=$messageid');">$img[im_remove]</a>
Line 232:

Code Select Expand

if ($action == 'im') { include_once "$sourcedir/InstantMessage.php"; IMIndex(); }

[Wiziwig]

Thanks for the bug report, strange that it's not been found by anyone else yet. Where are you making these corrections? index.php?

[Daniel D.]

Sorry, these are the lines with the bugs . Do you see the error ? I can't handle PHP good enough to see that.

[Wiziwig]

Maybe you didnt apply the mod or that %^% boardmod didnt apply. You should have in instantmessage.php at and along that reported line (256 to 274) this:

Code Select Expand

EOT;

// ENH IM

if ($modSettings['enableReportToMod'] == '1')
   print "<font size=1><a href=\"mailto:$webmaster_email\">$img[report]</a></font>";

}

// This marks the spot where I finished making changes

print <<<EOT
   <a href="javascript:DoConfirm('$txt[154]?','$cgi&action=imremove&caller=1&id=$messageid');">$img[im_remove]</a>
        </font></td>
      </tr>
    </table>
    </td>
  </tr>
EOT;


[Daniel D.]

It seems, that the *.mod file is "corrupt". There are some errors:

Code Select Expand

<add after>
// ENH IM         
         $msn = $userprofile[$musername]['MSN'];
            if (OnlineStatus($musername) > 0) { $sendIM = $img[message_sm_on]; } else $sendIM = $img[message_sm_off];
               $sendm = "$menusep<a href=\"$cgi;action=imsend;to=$musername\">$sendIM</a>";
//
</search for>The tags are different, but this isn't the solution.

Code Select Expand

<search for>
if (!$deleted) {
   print <<<EOT
   <a href="$cgi&action=imsend&caller=1&imsg=$messageid"e=1&to=$musername">$img[replyquote]</a>$menusep<a href="$cgi&action=imsend&caller=1&imsg=$messageid&reply=1&to=$musername">$img[im_reply]</a>$menusep
EOT;
}
print <<<EOT
</search for>


<replace>
if (!$deleted) {
   print <<<EOT
   <a href="$cgi&action=imsend&caller=1&imsg=$messageid"e=1&to=$musername;ry=1">$img[replyquote]</a>$menusep<a href="$cgi&action=imsend&caller=1&imsg=$messageid&reply=1&to=$musername;ry=1">$img[im_reply]</a>$menusep
EOT;

// ENH IM

if ($modSettings['enableReportToMod'] == '1')
   print "<font size=1><a href=\"mailto:$webmaster_email\">$img[report]</a></font>";

}

// ENd ENH IM
</replace>Is it right that you miss "print <<<EOT" here ? Hmm, but that's not the point ! I'm getting now some error in line 483 in InstantMessage.php.

Can't figure it out...

[Wiziwig]

instead of using boardmod try modding a virgin instantmessege.php by hand. If you find this to be difficult im me with your email address and I'll send you the php file. This mod change has been tested not only by me but also by another web op dev, for all theory applied it should be working. Besides, your pointing errors out to code lines that I had not modified, indicating that there must be a mod process error (boardmod?).

[Daniel D.]

...If you find this to be difficult im me...

No, it's not that difficult . Hmm, I should think about that next time

* Daniel D. is a noob*

Besides, your pointing errors out to code lines that I had not modified...

I know, it's still strange because after uninstalling it, the board works ! I checked the modifications - only the ones from the file.

Ok, I'll test the "Human BoardMod" ...

[Wiziwig]

no no not saying or refering that you are a * noob * . Shoot I can see your not, you're a "" yabb god "" .. Pardon if I offended thee oh great and mighty one! It could very well be my interpretation of how I was supposed to had written the mod for boardmod to work with it. Seriously, do me the favor and pass me your mail and I'll send you my copy of instantmsg. If it works let me know and I'll go back over line by line the mod file..

[Daniel D.]

Hey, don't worry ! I made a joke about myself !!

It's good if you can do this ! It wakes me up !

[Wiziwig]

Ok great! I'm happy to oblige with the humor, it helps you guys get this yabb in the fine art you've made it into. Now, may I please have your email? (offering up the slaughtered lambs to the yabb gods)  

[Daniel D.]

Hmm, "Human BoardMod" didn't work.

Code Select Expand

Parse error: parse error, unexpected '<' in E:\wampp2c\htdocs\yabb14\Sources\InstantMessage.php on line 260

Fatal error: Call to undefined function: imindex() in E:\wampp2c\htdocs\yabb14\index.php on line 232
Ok, one thought before the address :
There are some lines in 'InstantMessage.php', which exists several times. BoardMod starts to search from the beginning after each command, therefore it's hard to insert a mod which has to change these parts. You have to grab big parts with <search for> and change them with <replace>. But it's only a thought, I think you know that...

[Wiziwig]

I mailed you, thanks! If try the attachment and if it works then I'll re-work that ^&^ mod file..

(slaughters the sacrificial sheep with enjoyment to vent his frustrations)

[Daniel D.]

Worked with your file !

[CandyMann_69]

I was just curious what features this mod had.  I was looking at the mod for yabb 1 Gold and was thinking about what improments might be made to the IM.

http://boardmod.yabbforum.com/mods.php?searchfor=aimb_2_sp11-final.zip

Description: Advanced IM Box 2.0 for YaBB 1 Gold - SP 1.1

New in V2.0:
- BuddyList
- Prev-Next Links to IM-Display
- List ALL Messages on IM-Display
- checkbox for checking all IMs for delete
- whole Subject cell is now a link to view the IM
- Admin can see the IP of the sender
- moved IM-Preferences completely to Modify-Profile
- Bug with multiple IMs fixed
- Storage Box (thx to Homey for the idea and his mod)
- IM Preview choosable
- User can choose to view IMs in same window or in a new window
- user online status
- option for admins to send all users an IM by MemberGroups
- security popup on deleting messages
- SP1.1 style icons
- Instant Message restrictions
- enable/disable popup and sound as default for new regged users
- ability to call Instant Messages back from recipient
- print Instant Messages
- ability to setup an auto-away message
- reply/quote without open Instant Messages
- percent of box - usage if Instant Messages are limited