[Done 1.4.1] Merge/Split Threads Mod 3.5

[Nossie]

I cocked this up for sure with the capital S (gonna work on that...)

not sure about the grad either because its different from the button templates that site makes....

I'll replace it with the small s in 5

comments?

thanks...

[Mach8]

Yeah that's perfect

[Nossie]

ok.. done

ya'd better make this a good mod now

lol  

[Mach8]

So... how can I make it a better mod

[Nossie]

do it so that when the thread is split... a comment is made with some form of refrence to the original thread ? (from the splitter)

dunno about the merge.... I think it would be better if you could merge it to the bottom of the thread... no ?

the top might knock the original topic of context...

maybe a comment to say that the two threads had also been merged? (not sure about that one)

something like that I think.. hehe tho I think its already been brought up previously...

urm.. cant think of much else apart from dodgy error trapping (being able to split the base topic....)

[Nossie]

here is a thought...

have you tried it with the "View Newest Messages First" option?

just wondering

[Shaun]

dunno about the merge.... I think it would be better if you could merge it to the bottom of the thread... no ?

the top might knock the original topic of context...

That's the only thing I think is needed for sure.  Then I would love this mod!

[Mach8]

I'm not sure what you both mean

Perhaps a screenshot or a detailed explanation? The way it merges them at the minute is it simply puts both threads under the same topic ID, so all the contained messages are ordered by their post date.

[groundup]

well.. maybe they shouldn't be ordered in that manner.  I think it would be better to order them just by one thread after the other.  Would fixing the topics break that though?

[Nossie]

ut oh....

so if I post  on a busy board


message A1 in topic 1... at 2pm
message A2 in topic 2... at 2:40pm

message B1 in topic 1... at 3pm
message B2 in topic 2... at 5pm

then when you merge the 2 it will look like..

A1 topic 1
A2 topic 2
B1 topic 1
B2 topic 2

?

err... I think *lol*

[Mach8]

Well to do one thread after another you'd have to "make up" post dates for the second thread added to the new thread, because Display.php orders them by post date/time. On other forum software I've seen it done like this. Ah well

[Nossie]

instead of...

A1 topic 1
B1 topic 1
A2 topic 2
B2 topic 2

[Shaun]

The way it merges them at the minute is it simply puts both threads under the same topic ID, so all the contained messages are ordered by their post date.

I thought what Nossie meant by "I think it would be better if you could merge it to the bottom of the thread" was that the replies wouldn't be sorted in the order posted.  I was already commenting on the mod before I finished installing it!  Shame on me.  Shame...shame.

In your .mod file, you just need to correct the
<open file>
Display.php
</open file>

to

<open file>
Sources/Display.php
</open file>

This mod kicks @$$!  Thank you.

[Nossie]

but shaun.... wont it split up conversations in both threads instead of tying them both together?

on the thought of numbering... since one thread is being modified after all... does it matter the dates are 'reset' or something?


hehe excellent mod tho mach....
great job on your part !

[Shaun]

Hmmmm...I suppose it would.  I'm just counting on my mods splitting threads before an "off-topic" conversation gets started.

I attached a picture of where I put my buttons.