A private board visible to "outsiders"

[Monte-Cristo]

OK, this might not be a bug, maybe it's even intentional, and it doesn't bother me a lot, but anyway - the private board on my forum is visible (well, the fact that it exists is visible, they can't actually reach it) in the Top 10 boards section of the Statistics Center. It might be good to eliminate that chance, you know how people freak out when they notice that some of the guys are conspiring right in their backyard, even though they've officially known it...  

[Hypocrite]

If I remember correctly this has been discussed before and this feature is by design.

[christoffer]

You can fix the problem by editing a few lines in the recent posts source file (think it is called Recent.php). When the "where" criteria is being specified in the sql commands add BOARD_ID <> '17' if 17 is the number of the private board you want to hide.

This will prevent the messages from showing up in the info center on the board index. The topic titles from the internal forums might still appear in the stats page though (10 most popular, most replies etc), but there is probably a similar way to fix that...

To remove the the "last post" info displayed next to the forum title/description on the board index, in the BoardIndex.php file search for this text string:

"$latestPostTime<br />$txt[yse88] <a href=\"$scripturl?board=$row_board[ID_BOARD];action=display;threadid=$topicID;start=$startPage;boardseen=1\">$subject</a><br> $txt[525] $latestPostName</font>"

Replace this code with a variable, you can call it $lastpostprint.

A few lines above, just above "print <<<EOT", insert this code:

if($row_board[ID_BOARD] == '17'){$lastpostprint="no info available";}else{$lastpostprint = "
$latestPostTime<br />$txt[yse88] <a href=\"$scripturl?board=$row_board[ID_BOARD];action=display;threadid=$topicID;start=$startPage;boardseen=1\">$subject</a><br> $txt[525] $latestPostName</font>
"; }

where 17 is the number of the board you want to hide. If the board is internal, "no info available" will be displayed, otherwise the normal last post info will appear.

Keep in mind that this probably isnt the best way to solve the problem, since it will also hide the information to the members who have actually got access to the private forums.

Christoffer

[theo]

You can fix the problem by editing a few lines in the recent posts source file (think it is called Recent.php). When the "where" criteria is being specified in the sql commands add BOARD_ID <> '17' if 17 is the number of the private board you want to hide.................

Holy crap, my board looks like an open book. Please could you explain it for an idiot like me? I don't know wich lines I have to change.

[christoffer]

Hi Theo,
I dont know if you have to change all of these mysql queries, but here is what I have done:

In Recent.php: The first function is called LastPost

In line 3 of this function find the "request"-string:
$request = mysql_query("SELECT m.posterTime,m.subject,m.ID_TOPIC,t.ID_BOARD,m.posterName,t.numReplies,t.ID_FIRST_MSG FROM {$db_prefix}messages as m,{$db_prefix}topics as t,{$db_prefix}boards as b,{$db_prefix}categories as c WHERE (m.ID_TOPIC=t.ID_TOPIC && t.ID_BOARD=b.ID_BOARD && b.ID_CAT=c.ID_CAT && b.ID_BOARD<>'17' && (FIND_IN_SET('$settings[7]',c.memberGroups)!=0 || c.memberGroups='' || '$settings[7]' LIKE 'Administrator' || '$settings[7]' LIKE 'Global Moderator')) ORDER BY m.posterTime DESC LIMIT 1");


You should add what I have marked with bold, in this example your board-id is 17. Of course, if you have more internal boards, just add another "&& b.ID_BOARD <> xx" next to the string in bold.

Now find the function RecentPosts and find the request line:

$request = mysql_query("SELECT m.smiliesEnabled,m.posterTime,m.ID_MEMBER,m.ID_MSG,m.subject,m.body,m.ID_TOPIC,t.ID_BOARD,b.name as bname,c.name as cname,m.posterName,t.numReplies FROM {$db_prefix}messages as m,{$db_prefix}topics as t,{$db_prefix}boards as b,{$db_prefix}categories as c WHERE (m.ID_TOPIC = t.ID_TOPIC AND t.ID_BOARD = b.ID_BOARD AND b.ID_BOARD<>'17' AND b.ID_CAT=c.ID_CAT AND (FIND_IN_SET('$settings[7]',c.memberGroups)!=0 OR c.memberGroups='' OR '$settings[7]'='Administrator' OR '$settings[7]'='Global Moderator')) ORDER BY m.posterTime DESC LIMIT $display");


Look a few lines below and find request2:
$request2 = mysql_query("SELECT m.posterName,m.ID_MEMBER FROM {$db_prefix}messages as m,{$db_prefix}topics as t WHERE (m.ID_MSG=t.ID_FIRST_MSG && m.ID_BOARD<>'17' && t.ID_TOPIC=$row[ID_TOPIC])");
      

Finally in the function LastPostings, find this line:

$request = mysql_query("SELECT m.posterTime,m.subject,m.ID_TOPIC,t.ID_BOARD,m.posterName,m.ID_MEMBER,t.numReplies,t.ID_FIRST_MSG FROM {$db_prefix}messages as m,{$db_prefix}topics as t,{$db_prefix}boards as b,{$db_prefix}categories as c WHERE (m.ID_TOPIC=t.ID_TOPIC && t.ID_BOARD=b.ID_BOARD && b.ID_CAT=c.ID_CAT && b.ID_BOARD<>'17' && (FIND_IN_SET('$settings[7]',c.memberGroups)!=0 || c.memberGroups='' || '$settings[7]' LIKE 'Administrator' || '$settings[7]' LIKE 'Global Moderator')) ORDER BY m.posterTime DESC LIMIT 0,$showlatestcount");


   
Hope you can use this  

[Jeff Lewis]

geez guys...for those of you who think that their private boards are being shown in the recent topics - they aren't. Logged in as admin you WILL be able to see that - obviously. But if you log out, you will see a different topic.

Recent topics in admin boards aren't displayed if you don't have permission to private boards.

As for the stats area, it lists the name of them but people don't have access to them.

[theo]

2 christopher, many thanx for ya explanation  
At the moment it didn't work for me. I'll try it again tomorrow. Maybe I typed in a mistake. In my Forum there are 5 Boards where I wish that they aren't visible in the stats for the whole public. So I repeated it in all 4 functions you suggest.  At the moment it seems that I've tomatos on my eyes and I disabeld the the stats function in admincenter. That works for the moment  

2 Jeff - you're right, the private boards aren't shown in the recent posts for the whole public. But the counter shows the whole public howmany threads and topics existing. And it isn't cool if a guest can click the link [more stats] and can see that the most viewed topic is "latest password for...." in the PWD-Thread in Private Board  

I don't know whether this situation is a bug in 1.4  or not   I could remember to other yabb versions that this thing wasn't in this way.

[Jeff Lewis]

It's always been like this in SE because I wrote the stats feature To my knowledge it has never been in the Perl version unless someone recently wrote a MOD for it.

[theo]

I'm realy new in the buisiness to running a board (think 4 Month)  
Don't could remember how it works in 1.3, time was to short for me to work with it before I updated to 1.4 but I believe that you're right cause I think you know what you're doing  

Before I start with YaBB SE, Iworked with a pl version called GYP (GermanYabbProject). I know 100% that this YaBB is/was "water-resistend" in this kind. There's  also a statistic feature called Who.pl. Not the same like this but similar. A good thing in the Who.pl was that you could see, wich members and howmany guests visited the board in the last 24 hours.

Sh.., I've to go to work. See ya later....

Cheers

[christoffer]

doohh...thanks for letting us know Jeff...

This board really is perfect!