[Done 1.4.1] Merge/Split Threads Mod 3.5

[Dancer]

Hi.

First of all thank you Mach8 for this great mod. It's really useful.

But I have two explicit problems with it.
I installed version 3.5 with BoardMod SE on a fresh YaBB 1.4.1
And uploaded all files including MergeThreads.php and SplitThreads.php (CHMOD 666) to the server...

Sorry, my English isn't very good. I hope you'll understand my problems which im going to explain right now.

The problems I have occur when I use the merge-function. Split seems to work properly with all its options. When you split a thread you get the message 'Thread successfully split' an the three links to the thread-index, the original thread and the new thread. When I merge two threads I don't get the message 'Threads successfully merged!' and the links to the thread-index an the merged thread don't appear. I have to klick on the button 'Home' to reach the template an the merged thread.

But there is another problem when I merge two threads. Imagine the following situation. We have a thread called 'test 1' with the thread ID=1 and we have a second thread called 'test 2' with the thread ID=2. In each thread you find three posts. So far so good. Now I want to merge both threads an the posts of 'test 1' shall be added at the end of 'test 2' and that the merged thread shall keep the title 'test 2'. Ok, now I choose 'merge' at 'test 1' (ID=1) and fill in the destination ID of 'test 2' -> ID=2.
The threads now are merged together. But not in the way I wanted it to be.
The posts of 'test 1' are added at the beginning of 'test 2' and not at the end and the merged thread now has the title 'test 1' and not 'test 2'.
After this test I startet some new tests and found out the following:
When two threads are merged, the posts of the thread with the smaller ID are always set as the first posts in the merged thread.
Is there a possibility to fix this? So that you can choose whether the posts of the actual thread shall be added at the end or at the beginning of the merged thread? Or that the thread in which you click on the merge-button will always be added at the end of the merged thread?

I hope you understand what I mean....
Sorry for this long post, but I didn't know how to explain it in a shorter way.
I hope that someone can give me a solution for these two problems.  


Greets
Dancer

[Mach8]

Okay, the lack of a "Threads merged" message is probably an oversight of mine when I was changing the code earlier, I will look into it when I get home tonight.

As for the order not being what you want when you merge threads... this is how YaBB SE works, and is beyond my control. The threads are joined together, but are still ordered by the date they were posted. The only way to order them as you want would to artifically alter the date they were posted, which would, in my opinion, be a wrong thing to do.

[Dancer]

Okay, the lack of a "Threads merged" message is probably an oversight of mine when I was changing the code earlier, I will look into it when I get home tonight.

Okay, thank you very much.

As for the order not being what you want when you merge threads... this is how YaBB SE works, and is beyond my control. The threads are joined together, but are still ordered by the date they were posted. The only way to order them as you want would to artifically alter the date they were posted, which would, in my opinion, be a wrong thing to do.

Oh yeah, you're right. Sorry this was a fault of mine. I thought in a wrong way. It's been too late last night.
I made a 'logical mistake'. The situation I described won't appear when merging two threads because the posts of the newer one will always be added at the end of the merged thread as it should be...
Sorry, as I said, a 'logical mistake'.


Greets
Dancer

[Mach8]

No problem, and thanks for using the mod

[Koth]

I have to say I have been using this Mod for quite a while now and its a corker thanks very muchly for the hard work

[groundup]

to change the order, you would have to edit a query that selects all of the posts from a topic. Changing order by (whatever the date field is called) to nothing and then creating your own ordering system.

[Beertje]

Don't know if someone already reported this one?

If I split a message (I used "split this and following messages"-option) which is the last post on a board and create a new topic with it, the new topic is not shown as the last post on the boardindex (as it should be).
Instead of that, the last post shown on the boardindex is the last reply of the original message.

I know the new topic ID must be updated in the table yabbse_boards in the field ID_LAST_TOPIC, but I don't know how.

Other combinations where this error can occur:

• Use "only split this message" and it's the last post
• Use "select message to split" and you select the last post

[Mach8]

Thanks for highlighting this, it was an oversight on my part. A new version fixing this will be released soon.

[anagolightly]

It  is not working for me :( I uploaded the merge spilt mod to my test sources...then the other two php mods given but it never worked. I also added the gif's to....what did i do  wrong? Thank you.

[tore-]

i had the same problem, i had no problem with the install, but when i tryied to log onto the board, i get logged out at once i clicked a link... no cookie problem since i dont use cookies

[Mach8]

I can't think exactly what would be wrong, check you've done the following:

1) Modified index.php
2) Uploaded index.php, MergeThreads.php, SplitThreads.php, merge.gif, split.gif
3) CHMOD-ed the scripts if necessary

[Colm]

It's working like a champ for me. It's quite a useful mod for all those folks who post in the wrong place.

[Mach8]

I know the new topic ID must be updated in the table yabbse_boards in the field ID_LAST_TOPIC, but I don't know how.

Are you using Compuart's SpeedUpBoardIndex mod by any chance?

[Mach8]

Current Status Of The Mod:

• YaBB SE 1.5.0 - coming out in the near future - will include the mod as a standard feature


• Soon after the release of this version I will bring out a version of this mod with a few bug fixes (thanks Compuart) for those of you who don't want to upgrade to 1.5.0. As far as I'm aware the mod will work on versions back to 1.3.0, maybe further (although I haven't tested that).

If you have a last minute request for the mod, please declare it now as it needs to be incorporated into 1.5.0. Thanks.

[DJTommyC]

I've tried to install this mod on YaPP but I can't get it to work..
I used boardmod (2.5.1)..
Anybody can HELP???
Thx..