[BETA] Bookmarks

[Joseph Fung]

This is a betat version of the bookmarks available here at yabbse.org

Note, this mod does, unfortunately impact several key queries in Profile.php and Load.php, backup before trying this thing out.

Again, I reiterate this is a beta for 1.5

[percherie]

Sorry, the mod don't find the caractère "?>" in the file "subs.php" and the bookmarks don't display in the forum 1.5

[BiErLeEuW]

Help of this file?

first run the mod's and then the database changes? (+ place bookmarks.php?

[Mr.Sins]

I manualy edit the mod file to be compatible with my other mod changes.

installation worked.
db update worked.
i enable the mod in my admin center.

but i still don't see the bookmarks

[Mr.Sins]

Help of this file?

first run the mod's and then the database changes? (+ place bookmarks.php?

i guess you have to place it in your Source folder
and you have to go to admin center and enable the mod in the mod settings.

[Mr.Sins]

the checkbox doesn't work in modsettings if i check it and then go back its back unchecked

Solution add the following row to yabbse_settings
showBookmarks       1

now the check box works, but i still don't see the bookmars future on my boards

[Mr.Sins]

stupid question i see that you add the function yybookmarks() to the subs file.

but i can't find no point in your mod where you call that function

[David]

stupid question i see that you add the function yybookmarks() to the subs file.

but i can't find no point in your mod where you call that function

Template header in subs.php is what calls it.

[Mr.Sins]

when i search through subs.php i only find the function yyBookmarks()

but i don't find the entry point where you call it

code of yybookmark

Code Select Expand

function yyBookmarks()
{
   global $settings, $db_prefix, $ID_MEMBER, $username, $txt, $yytitle, $scripturl, $HTTP_SERVER_VARS, $modSettings;

   if ($username != 'Guest' && $settings[24]=='1' && $modSettings['showBookmarks'] == '1')
   {
      $sql = 'SELECT url, title FROM ' . $db_prefix . 'bookmarks WHERE ID_MEMBER=' . $ID_MEMBER . ' ORDER BY display_order';
      $request = mysql_query ($sql);
      ?>
      <script>
      function addOption(theSel, theText, theValue)
      {
         var newOpt = new Option(theText, theValue);
         var selLength = theSel.length;
         theSel.options[selLength] = newOpt;
      }
      </script>
      <?php
      echo '<table border=0 cellspacing=0 cellpadding=0><form name="bookmarkFrm"><tbody><tr><td><b>' . $txt['bookmarks1'] . '</b> <select name="bookmarks" onchange="window.location.href=this.options[this.selectedIndex].value;">';

      while ($row = mysql_fetch_assoc($request))
         echo '<option value="' . $row['url'] . '">' . $row['title'] . '</option>';         

      $addUrl = $scripturl . '?action=bookmarks;sub=add;title=' . urlencode($yytitle) . ';url=' . urlencode(urlencode($scripturl.'?'.$HTTP_SERVER_VARS['QUERY_STRING']));

      echo '</select> <input type=button value="' . $txt['bookmarks8'] . '" onclick="window.location.href=bookmarks.options[bookmarks.selectedIndex].value;"> <input type=button value="' . $txt['bookmarks2'] . '" onclick="window.location.href=\'' . $addUrl . '\';"> <input type=button value="' . $txt['bookmarks3'] . '" onclick="window.open(\'' . $scripturl . '?action=bookmarks;sub=edit\',\'bookmarks\',\'toolbar=no,location=no,status=no,menubar=no,scrollbars=no,width=500,height=220,resizable=no\');"></td></tr></tbody></form></table>';
   }
}
but where is it called

[Mr.Sins]

linux:/srv/www/html/yabbse/Sources # grep yyBookmark *
Subs.php:function yyBookmarks()
linux:/srv/www/html/yabbse/Sources # cd ..
linux:/srv/www/html/yabbse # grep yyBookmark *
linux:/srv/www/html/yabbse #

[Joseph Fung]

I guess it wasn't really obvious - you need to add a <yabb bookmarks> tag into your template.  

[Mr.Sins]

: mysql_fetch_assoc(): supplied argument is not a valid MySQL result resource
(/srv/www/htdocs/yabbse/Sources/Subs.php ln 1318)

[Mr.Sins]

change this

Code Select Expand

$sql = 'SELECT url, title FROM ' . $db_prefix . 'bookmarks WHERE ID_MEMBER=' . $ID_MEMBER . ' ORDER BY display_order';

to

Code Select Expand

$sql = 'SELECT url, title FROM ' . 'bookmarks WHERE ID_MEMBER=' . $ID_MEMBER . ' ORDER BY display_order';

its seem you have some litle bugs in your db install file
you forgot to name your db yabbse_bookmarks

[Mr.Sins]

instead of changing the code, you just better rename the table from bookmarks to yabbse_bookmarks

everything works fine, for now.

thx for this great mod

[Joseph Fung]

instead of changing the code, you just better rename the table from bookmarks to yabbse_bookmarks

everything works fine, for now.

thx for this great mod

No problem - I'll try to post an updated BETA tomorrow.  I want to get this thing released as a final mod in a day or two.