[Code 1.5.x] Karma ++/-- Bugfix

[Spaceman-Spiff]

The bug
If you smite someone (-), then right after, applaud him, he'll get a ++. This was done to compensate the first one (in case someone clicked on the wrong link). It worked okay in the older version of Karma feature, but in since yse 1.5.0 or 1.5.1 (can't remember), we can view Karma as positive/negative, not just as total.

The fix
Open Karma.php, search for

Code Select Expand

      $request = mysql_query("UPDATE {$db_prefix}members SET $field=$field+$change WHERE ID_MEMBER='$uid' $doLimitOne;") or database_error(__FILE__, __LINE__);replace with

Code Select Expand

      // Karma bug fix
      if ($change == 2)
      {
         $field2 = (($dir == '+') ? 'karmaBad' : 'karmaGood');
         $request = mysql_query("UPDATE {$db_prefix}members SET $field=$field+1, $field2=$field2-1 WHERE ID_MEMBER='$uid' $doLimitOne;") or database_error(__FILE__, __LINE__);
      }
      else
         $request = mysql_query("UPDATE {$db_prefix}members SET $field=$field+$change WHERE ID_MEMBER='$uid' $doLimitOne;") or database_error(__FILE__, __LINE__);

[Ruthie]

Hi there,
That sort of worked... but I'm still able to go applaud, then smite, then applaud, then smite, then applaud, then smite... so if I had the time and wanted to be a twit I could make someone go from +1/-1 to +121/-121 in one night, even though the karma restriction is set to once every 12 hours.

Is there a fix for that?

Thanks

[Spaceman-Spiff]

the code above should fix that, it it will reduce your previous vote by 1 and add the new vote by 1, instead of adding the new vote by 2 (in current YSE 1.5.4)

and i'm sure this has been fixed for SMF 1.0

[Ruthie]

You're right... I tested it late at night and didn't check the applaud and smite totals   when I was testing.. so all I saw was it go up/down/up/down/up/down and assumed that meant applauds and smites were both going up.

Thanks for your help!

[[Unknown]]

Hi there,
That sort of worked... but I'm still able to go applaud, then smite, then applaud, then smite, then applaud, then smite... so if I had the time and wanted to be a twit I could make someone go from +1/-1 to +121/-121 in one night, even though the karma restriction is set to once every 12 hours.

Is there a fix for that?

Thanks

You are probably an administrator.  You can do anything without restriction .

-[Unknown]

[Ruthie]

Hi there,
That sort of worked... but I'm still able to go applaud, then smite, then applaud, then smite, then applaud, then smite... so if I had the time and wanted to be a twit I could make someone go from +1/-1 to +121/-121 in one night, even though the karma restriction is set to once every 12 hours.

Is there a fix for that?

Thanks

You are probably an administrator.  You can do anything without restriction .

-[Unknown]

Yup I am... but I've been around these forums long enough to know that I have to change my account to that of a regular user before testing suspected bugs.

[BrandonMiller]