Search by Subject or Message

[A.M.A.]

Is this the best way to make "search" do a specific search by subject,  message or both of them:

else if ($userkind == 3 && $userspec == '' && $searchsubject == 'on' && $searchmessage == 'on')
  $where = "($boardsWhere m.ID_TOPIC=t.ID_TOPIC && m.ID_MEMBER != -1 && (INSTR(LOWER(m.subject),'$query') || INSTR(LOWER(m.body),'$query')) && m.posterTime <= $mintime && m.posterTime > $maxtime)";

else if ($userkind == 3 && $userspec != '' && $searchsubject == 'on' && $searchmessage == 'on')
  $where = "($boardsWhere m.ID_TOPIC=t.ID_TOPIC && m.ID_MEMBER != -1 && m.posterName='$userspec' && (INSTR(LOWER(m.subject),'$query') || INSTR(LOWER(m.body),'$query')) && m.posterTime <= $mintime && m.posterTime > $maxtime)";


else if ($userkind == 3 && $userspec == '' && $searchsubject == 'on')
  $where = "($boardsWhere m.ID_TOPIC=t.ID_TOPIC && m.ID_MEMBER != -1 && (INSTR(LOWER(m.subject),'$query') ) && m.posterTime <= $mintime && m.posterTime > $maxtime)";

else if ($userkind == 3 && $userspec == '' && $searchmessage == 'on')
  $where = "($boardsWhere m.ID_TOPIC=t.ID_TOPIC && m.ID_MEMBER != -1 && (INSTR(LOWER(m.body),'$query')) && m.posterTime <= $mintime && m.posterTime > $maxtime)";


else if ($userkind == 3 && $userspec != '' && $searchsubject == 'on')
  $where = "($boardsWhere m.ID_TOPIC=t.ID_TOPIC && m.ID_MEMBER != -1 && m.posterName='$userspec' && (INSTR(LOWER(m.subject),'$query') ) && m.posterTime <= $mintime && m.posterTime > $maxtime)";

else if ($userkind == 3 && $userspec != '' && $searchmessage == 'on')
  $where = "($boardsWhere m.ID_TOPIC=t.ID_TOPIC && m.ID_MEMBER != -1 && m.posterName='$userspec' && (INSTR(LOWER(m.body),'$query')) && m.posterTime <= $mintime && m.posterTime > $maxtime)";

or there is a better way for reducing those IF statements!

cheer

[[Unknown]]

HAHA!  Yes, I've redone that hole mess....

-[Unknown]

[A.M.A.]

HAHA!  Yes, I've redone that hole mess....

-[Unknown]

You mean in your SP ... am planning on releasing a mod to make search functions better, but I still think this is not the right way  

cheer

[A.M.A.]

may be if I make the fields as a variable , will be better.


cheer

[Anguz]

you mean adding the option of searching in subject and/or message? isn't that option in Advanced Search already?

or you mean the way the script does it is not very good and it can be better?