[Done 1.4.0][CODE] Number of posts correction with RemoveThread.php

[Webby]

Even better !

There is now also a possible "danger" :

members who want to be "topposter" can post topics, and delete them right away. Post, delete, post, delete......etc.

The result : a high postcount........

Sssssttt........don't tell  

[[Unknown]]

Okay, here's the full changes...

RemoveThread.php:
Find:

Code Select Expand

  $request = mysql_query("DELETE FROM {$db_prefix}messages WHERE ID_TOPIC=$threadid;") or database_error(__FILE__, __LINE__);
Replace:

Code Select Expand

  $request = mysql_query("DELETE FROM {$db_prefix}messages WHERE ID_TOPIC=$threadid;") or database_error(__FILE__, __LINE__);
  if (mysql_affected_rows($request) == 1)
  {
     $temp = mysql_fetch_row($request2);
     if ($temp[0] != '-1')
        mysql_query("UPDATE {$db_prefix}members SET posts=posts-1 WHERE ID_MEMBER='$temp[0]';") or database_error(__FILE__, __LINE__);
  }

Find:

Code Select Expand

   while ($temp = mysql_fetch_row($request2))
      if ($temp[0] != '-1')
         $request = mysql_query("UPDATE {$db_prefix}members SET posts=posts-1 WHERE ID_MEMBER='$temp[0]';") or database_error(__FILE__, __LINE__);

   $yySetLocation = "$cgi";
Replace:

Code Select Expand

  $yySetLocation = $cgi;

-[Unknown]

[Webby]

Changed it, but what does it exactly do or doesn't do ?

[[Unknown]]

This change makes it so that the post count will be reduced if there is only one post.

-[Unknown]

[Webby]

Great !

Thanx for the quick and neat solution

[Henk]

This change makes it so that the post count will be reduced if there is only one post.

-[Unknown]

I´ve tried it several times, but I keep getting a MySQL error, something about a that an argument is not valid. After that the board says that the last post is n/a by n/a.

Think I keep making the same mistake in changing RemoveThreads (I have no idea how PHP works, so I only can follow your instructions, and even that is too hard for me this time)

I now simply changed SET posts=posts-1 into SET posts=posts. It works, postcounts don´t decrease anymore, but I have no idea if this can do any harm.