recentTopics in the new SSI.php

[Spaceman-Spiff]

In the new SSI.php (v.1.5.1) the queries have been changed a lot from v1.4.1. I heard its more optimized than the older version.

but one thing i don't like in the new (1.5.1) SSI.php recentTopics is u can get something like:

Recent Forum Topics:
» WooHoo by zip
» Re: Finally....it's here -_-||| by c
» Re: Finally....it's here -_-||| by f
» Re: Finally....it's here -_-||| by a
» Re: Finally....it's here -_-||| by b
» Re: Finally....it's here -_-||| by d
» Re: Finally....it's here -_-||| by c
» Finally....it's here -_-||| by e

the same topic can be repeated a few times
now i'm thinking of using the older SSI.php version
i'm just wondering how much difference does the new version make in the speed optimization?
is it really significant compared to v1.4.1?

[[Unknown]]

UNTESTED!!!

Change the first query in recentTopics from:
SELECT m.ID_MSG

To:
SELECT DISTINCT m.subject, m.ID_MSG

That /should/ do it.

-[Unknown]

[Spaceman-Spiff]

doesnt work
i also have tried SELECT DISTINCT t.ID_TOPICS, m.ID_MSG

also tried using GROUP BY t.ID_TOPICs, but that screws up the order

[Joseph Fung]

Ok - here's something that should work a little better

The problem is with

Code Select Expand

   $request = mysql_query("
      SELECT m.ID_MSG
      FROM {$db_prefix}messages AS m, {$db_prefix}topics AS t, {$db_prefix}boards AS b,{$db_prefix}categories AS c
      WHERE t.ID_TOPIC=m.ID_TOPIC specifically in the WHERE t.ID_TOPIC=m.ID_TOPIC line.  That's just checking to make sure the message is in the topic.  What you need is to change that part to WHERE m.ID_MSG = t.ID_LAST_MSG

Note, The reason that DISTINCT wasn't working is because DISTINCT looks for unique sets of results, not unique values for one field.

[[Unknown]]

Oops, my mistake.  I don't use DISTINCT all to much.  I shoulda' looked more closely at the query :$.

-[Unknown]

[Spaceman-Spiff]

thanks, will try it when i get home

[Spaceman-Spiff]

works great, thanks Joseph

i've also added this into the WHERE statement:
AND m.subject NOT LIKE '$txt[yse56]%'
so all the MOVED:... topics won't be shown

[Joseph Fung]

I'm glad it worked for you! And that's a great idea on the moved topics!