YaBB SE Community

Development => Completed mods => Topic started by: Joseph Fung on January 04, 2003, 06:22:20 AM

Title: [Tested BETA] Bookmarks 1.4.1 and 1.5.0
Post by: Joseph Fung on January 04, 2003, 06:22:20 AM
Here you go - this is almost ready to release, I'd just like one last round of tests if anyone has the time...


Edit:
I am adding the updated mod, now zip contains a updated mod file for 1.5.1 Final 4/19/2003

Nemey

Horseman german mod version:
http://www.h-h-c.de/downloads/bookmarks.rar
Title: Re:[Tested BETA] Bookmarks 1.4.1 and 1.5.0
Post by: snYpir on January 04, 2003, 04:29:27 PM
I love the mod - it is original and works well.

My only concern it the fact that it modifies some of the critical DB queries - which of course means that other mods that reference these queries (ie with board mod <search for> statements) won't install.

How do people feel about having a seperate DB query for mods such as this?

There is slightly more overhead, but it will conflict less with other mods.

Joseph - For my forum, I re-wrote the parts of your mod because I would rather have that seperate DB query than modify the original LoadUser() DB query.

I have emailed my version to you, Joseph (can't attach except on the original post).

As I said, this is a great mod, but as a rule I don't implement mods that change core yabb queries. I would personally prefer it if you changed the Load.php accordingly, but of course I am just one dude out of the thousands that frequent this board (so i'll understand if you don't change anything).

cheers ;)
Title: Re:[Tested BETA] Bookmarks 1.4.1 and 1.5.0
Post by: PioneeR on January 05, 2003, 06:06:40 PM
I have run the dbupdate (which completed ok).

Appled the mod.. no probs there either.

put <yabb bookmarks> in my template

and made sure that bookmarks were enabled.

But I cant see them!?

What have i done wrong??
Title: Re:[Tested BETA] Bookmarks 1.4.1 and 1.5.0
Post by: Ben_S on January 10, 2003, 05:36:39 PM
did you find out, I cant see em either :'(
Title: Re:[Tested BETA] Bookmarks 1.4.1 and 1.5.0
Post by: Mr.Sins on January 10, 2003, 06:10:41 PM
enable it in your mod settings section
Title: Re:[Tested BETA] Bookmarks 1.4.1 and 1.5.0
Post by: Ben_S on January 10, 2003, 06:18:14 PM
it is enabled
it is enabled in profile
have added <yabb bookmarks> to template
Title: Re:[Tested BETA] Bookmarks 1.4.1 and 1.5.0
Post by: PioneeR on January 11, 2003, 05:42:57 AM
I still have the same problem...  ???


it is enabled
it is enabled in profile
have added <yabb bookmarks> to template
Title: Re:[Tested BETA] Bookmarks 1.4.1 and 1.5.0
Post by: PioneeR on January 11, 2003, 06:13:48 AM
I can alter the Enable Bookmarks in my profile fine.

But everytime I try to enable it in Mod Settings.. it goes back to unticked?  ???

I didnt get any errors with the dbchanges...

Title: Re:[Tested BETA] Bookmarks 1.4.1 and 1.5.0
Post by: [Unknown] on January 11, 2003, 06:21:49 AM
Is the mods setting even in your database?  I would double check...

-[Unknown]
Title: Re:[Tested BETA] Bookmarks 1.4.1 and 1.5.0
Post by: PioneeR on January 11, 2003, 06:22:07 AM
It is working for me kind of.

I cant seem to turn it on/off in mod settings!?!?
Title: Re:[Tested BETA] Bookmarks 1.4.1 and 1.5.0
Post by: PioneeR on January 11, 2003, 06:30:07 AM
In table yabbse_settings i have showBookmarks (which is set to 1)

I will double check to see if I have made a mistake when applying the change to modsettings.php  ;D
Title: Re:[Tested BETA] Bookmarks 1.4.1 and 1.5.0
Post by: PioneeR on January 11, 2003, 06:36:58 AM
I have checked and the following are there...

any ideas why I cant seem to control it from mod settings?

<Edit file>
Sources\ModSettings.php
</Edit file>

<Search for>
      $enableTrackStatsChecked = ($modSettings['trackStats'] == '1')?' checked':'';
       $enableHitStatsChecked = ($modSettings['hitStats'] == '1')?' checked':'';
</Search for>

<Add after>

   $showBookmarksChecked = ($modSettings['showBookmarks'] == '1')?' checked':'';

</Add after>

<Search for>
   $onoffArray['cal_AllowSpan'] = 'cal_allowspan';
</Search for>

<Add after>
   $onoffArray ['showBookmarksChecked'] = 'showBookmarks';
</Add after>

<Search for>
  </tr><tr>
    <td class="windowbg2" bgcolor="$color[windowbg2]" colspan="2" align="center" valign="middle">
    <HR size="1" width="100%" class="windowbg3"><input type="submit" value="$txt[10]">
    </td>
  </tr>
</Search for>

<Add before>
                     </tr><tr>
                        <td class="windowbg2" bgcolor="$color[windowbg2]" colspan="2"><hr size="1" width="100%" class="windowbg3" /></td>
                     </tr><tr>
                        <td class="windowbg2" bgcolor="$color[windowbg2]"><font size="2">$txt[bookmarks18]</font></td>
                        <td class="windowbg2" bgcolor="$color[windowbg2]"><input type="checkbox" name="showBookmarksChecked" value="1"$showBookmarksChecked /></td>
</Add before>
Title: Re:[Tested BETA] Bookmarks 1.4.1 and 1.5.0
Post by: Koth on January 11, 2003, 06:38:23 AM
So is the version thats up the one with the seperate query as I would rather have that version if at all possible.  This does look a quality and original mod and the extra "overhead" would be worth it since I run a heavilly modded YaBBse board.
Title: Re:[Tested BETA] Bookmarks 1.4.1 and 1.5.0
Post by: Ben_S on January 11, 2003, 02:07:53 PM
Mine has all the required DB entries, but doesnt show :(
Title: Re:[Tested BETA] Bookmarks 1.4.1 and 1.5.0
Post by: Lazy on January 13, 2003, 06:46:06 PM
hi =)

mine the same, all entries are made but it`s not shown hm.
Title: Re:[Tested BETA] Bookmarks 1.4.1 and 1.5.0
Post by: Vincent on January 23, 2003, 02:21:33 AM
anyone tested it for 1.5.1 ???
Title: Re:[Tested BETA] Bookmarks 1.4.1 and 1.5.0
Post by: PostDeals on January 26, 2003, 04:46:34 PM
I uploaded the files and added <yabb bookmarks>  in my template Yet I don't see it. I even ran the 1.5.0.php.yp file what could i be doing wrong.

Where in Installed 'Mods' Settings and Options   is the bookmark option? I dont see it.

Even trying to install i get this error;

An Error Has Occurred!

2: file("Packages/modification.mod") - No such file or directory
(/home/postdeal/public_html/yabbse/Sources/Packages.php ln 687)


Title: Re:[Tested BETA] Bookmarks 1.4.1 and 1.5.0
Post by: PoohBear on February 11, 2003, 07:56:53 AM
I installed this mod on my board running 1.5.1RC and although everything appeared to go OK and <yabb bookmarks> is correctly added in the template the bookmark box and associated buttons are not visible.

I have checked the mod options and the box is ticked?
Title: Re:[Tested BETA] Bookmarks 1.4.1 and 1.5.0
Post by: PoohBear on February 16, 2003, 02:26:48 AM
I don't have any errors but it is still not working? Probably something I have done (got?) wrong, anybody got any ideas?
 ???
Title: Re:[Tested BETA] Bookmarks 1.4.1 and 1.5.0
Post by: Joseph Fung on February 16, 2003, 03:08:08 AM
Are you absolutely sure you added the stuff to Subs.php and uploaded it correctly?
Title: Re:[Tested BETA] Bookmarks 1.4.1 and 1.5.0
Post by: PoohBear on February 16, 2003, 03:15:56 AM
I am 99% sure everything is uploaded correctly.
Just checked the Subs.php file and everything seems in order there....?

Mystery.. ???
Title: Re:[Tested BETA] Bookmarks 1.4.1 and 1.5.0
Post by: Ben_S on February 16, 2003, 08:21:36 AM
yep I'm sure it was all added too...
Title: Re:[Tested BETA] Bookmarks 1.4.1 and 1.5.0
Post by: PoohBear on February 16, 2003, 08:42:30 AM
yep I'm sure it was all added too...

Are you having the same problem Scotty_B?
Title: Re:[Tested BETA] Bookmarks 1.4.1 and 1.5.0
Post by: Joseph Fung on February 16, 2003, 12:38:03 PM
what are the url's to your site?
Title: Re:[Tested BETA] Bookmarks 1.4.1 and 1.5.0
Post by: Ben_S on February 16, 2003, 05:52:12 PM
I've since removed the mod so mines not much use
Title: Re:[Tested BETA] Bookmarks 1.4.1 and 1.5.0
Post by: ei8ht on February 17, 2003, 09:31:22 AM
Well,
i've installed this mod to a fresh installed 1.5.0 local on my system (running Windows NT5.1, Apache 1.3.20, php 4.0.6 and mysql 3.22)

I can install the mod very well, add the template tag and activate in the Mod Settings, but nothing shows.

I'm absolutly sure that i've made all steps correct, coz i repeated the procedure 4 or 5 time...

I don't know if this can help, but i found some diffrence between the mod strings and the original YaBB strings.

I'm not a very good php coder, so i don't know if this makes a diffrence.

greez

ei8ht

P.S. If you find some spelling or grammar misstakes, i'm from switzerland =)
Title: Re:[Tested BETA] Bookmarks 1.4.1 and 1.5.0
Post by: buster on February 20, 2003, 03:55:10 AM
I'll try to install this mod today i have runnig several mods so i hope this will work for me. Thnx for providing the mod.....
Title: Re:[Tested BETA] Bookmarks 1.4.1 and 1.5.0
Post by: amango on February 20, 2003, 10:54:00 AM
I have the same problem as most users here in this thread. After installing the mod and editing the template.php with "<yabb bookmarks>" nothing happens.

The bookmark-option won't show up. The database values are all correct. Maybe it's just a tiny error?
Title: Re:[Tested BETA] Bookmarks 1.4.1 and 1.5.0
Post by: GWP on February 22, 2003, 02:56:48 PM
I presume it must work Ok, as this board uses it (what versionis this board anyway?)
I would like this for my site and wait with eagerness for the 1.5.1 version :)
Title: Re:[Tested BETA] Bookmarks 1.4.1 and 1.5.0
Post by: Spaceman-Spiff on February 24, 2003, 12:38:26 AM
i cant save the bookmark changes that i've made in this site
when i click [save], it does nothing on Mozilla
it saves fine on IE 6 tho...
Title: Re:[Tested BETA] Bookmarks 1.4.1 and 1.5.0
Post by: Eloya on February 24, 2003, 02:38:31 AM
On Opera the same... ;)
No changes can be made.

Nico
Title: Re:[Tested BETA] Bookmarks 1.4.1 and 1.5.0
Post by: buster on February 28, 2003, 05:18:36 AM
Nothing happens at my board with the bookmark mod. I also have the signature mod  installed the signature mod uses a few lines wich are also used by the bookmark mod. I don't think that this is the problem. I run the board on lycos but i'm sure that that is no problem. It's a cool mod so i hope that anyone can solve this.

Installed mods:

Global moderator
Signature
Topic solved
Add more smilies
Who is online
Collabse yabb

All working fine
Title: Re:[Tested Beta] Bookmarks 1.4.1 and 1.5.0
Post by: buster on March 10, 2003, 01:45:09 AM
Well i have figured it out for my install.

In the bookmarks_dbchanges.php it doesnt add a line to the settings table in the database.

Add this line and it wil work
Title: Re:[Tested Beta] Bookmarks 1.4.1 and 1.5.0
Post by: Wistman on March 14, 2003, 05:44:17 PM
Just wondering if anyone has got this working yet

I have it set up everything is correct as per the mod, the tables are all there, <yabb bookmarks> tag is in my template but I do not get anything on the board
Title: Re:[Tested Beta] Bookmarks 1.4.1 and 1.5.0
Post by: buster on March 15, 2003, 09:46:55 AM
Just wondering if anyone has got this working yet

I have it set up everything is correct as per the mod, the tables are all there, <yabb bookmarks> tag is in my template but I do not get anything on the board
Just look into your {db_prefix}settings table if the bookmark is there if not add it and it will work i quess
Title: Re:[Tested Beta] Bookmarks 1.4.1 and 1.5.0
Post by: Wistman on March 15, 2003, 11:32:26 AM
Yes it is there and set to 1
Title: Re:[Tested Beta] Bookmarks 1.4.1 and 1.5.0
Post by: buster on March 15, 2003, 02:54:00 PM
Did you installed the db correct? Cause bookmarks_dbchanges.php creates a table called bookmarks and doesn't adds the prefix in front of it. Is the check box in modsettings checked or unchecked?? You should create showBookmarks in the settings table. I just installed it to my board with 26 other mods and it works fine.
Title: Re:[Tested Beta] Bookmarks 1.4.1 and 1.5.0
Post by: Wistman on March 16, 2003, 08:18:43 AM
Did you installed the db correct? Cause bookmarks_dbchanges.php creates a table called bookmarks and doesn't adds the prefix in front of it. Is the check box in modsettings checked or unchecked?? You should create showBookmarks in the settings table. I just installed it to my board with 26 other mods and it works fine.

Are you saying that the script is looking for a table named bookmarks or that the script looks for a table named { $db_prefix}bookmarks whilst the bookmarks_dbchanges.php creates a table called bookmarks has created a table without the { $db_prefix}? My table includes the prefix.

Can I ask if you installed bookmarks before or after the other mods? (having recently found out that some funtions rely on counted variables)
Title: Re:[Tested Beta] Bookmarks 1.4.1 and 1.5.0
Post by: Ben_S on March 16, 2003, 08:33:11 AM
Any chance of an update for 1.5.1
Title: Re:[Tested Beta] Bookmarks 1.4.1 and 1.5.0
Post by: oldiesmann on March 26, 2003, 09:13:11 PM
While I see this mod as useful, I also see a downside to it. By allowing users to jump directly to their favorite topic(s), it takes the fun out of having a messageboard because they don't get the chance to "stop" at other topics along the way and add their 2 cents worth to topics they might otherwise skip ;D
Title: Re:[Tested Beta] Bookmarks 1.4.1 and 1.5.0
Post by: Koth on April 01, 2003, 12:07:48 PM
Ok I have installed all the files via boarmod or by hand perfectly fine.  I have checked my database and I have both a table called Prefix_bookmarks and the entry for showbookmakrs in my prefix_settings table.

The option is checked in mod settings and my profile and the tag is in my template and still nothing works.
Title: Re:[Tested Beta] Bookmarks 1.4.1 and 1.5.0
Post by: Nemesis on April 18, 2003, 03:54:02 AM
Update for 1.5.1 Final Part 1:
Code: [Select]
<id>
Bookmarks
</id>

<version>
1.0 BETA
</version>

<mod info>
Note: This is the YaBB SE 1.5.1 Final version of this mod

This mod will create a drop-down list of "bookmarks".  You can easily add/remove/edit/reorder
these bookmarks.  You can create bookmarks to links within the forum, or to sites outside
the forum.
</mod info>

<author>
Joseph Fung
</author>

<homepage>
mailto:joseph_in_china@hotmail.com
</homepage>

<Edit file>
index.php
</Edit file>

<Search for>
      'yabbinfo' => array("$sourcedir/Admin.php", 'showYaBBInfo'));
</Search for>

<Add before>
      'bookmarks' => array ("$sourcedir/Bookmarks.php", 'Bookmarks'),
</Add before>


<Edit file>
Sources\ModSettings.php
</Edit file>

<Search for>
   $localCookiesChecked = ($modSettings['localCookies'] == '1' ? ' checked="checked"' : '');

</Search for>

<Add after>
   $showBookmarksChecked = ($modSettings['showBookmarks'] == '1' ? ' checked="checked"' : '');

</Add after>

<Search for>
      'cal_AllowSpan' => 'cal_allowspan');

</Search for>

<Add after>
   $onoffArray ['showBookmarksChecked'] = 'showBookmarks';

</Add after>

<Search for>
                     </tr><tr>
                        <td class="windowbg2" bgcolor="' . $color['windowbg2'] . '" colspan="3" align="center" valign="middle">
                           <hr size="1" width="100%" class="windowbg3" /><input type="submit" value="' . $txt[10] . '" />
                        </td>
                     </tr>
</Search for>

<Add before>
                     </tr><tr>
                        <td class="windowbg2" bgcolor="' . $color['windowbg2'] . '" colspan="3"><hr size="1" width="100%" class="windowbg3" /></td>
                     </tr><tr>
                        <td class="windowbg2" bgcolor="' . $color['windowbg2'] . '"></td>
                        <td class="windowbg2" bgcolor="' . $color['windowbg2'] . '"><font size="2">' . $txt['bookmarks18'] . '</font></td>
                        <td class="windowbg2" bgcolor="' . $color['windowbg2'] . '"><input type="checkbox" name="showBookmarksChecked" value="1"' . $showBookmarksChecked . ' /></td>
</Add before>


<Edit file>
Sources\Load.php
</Edit file>

<Search for>
      $request = mysql_query("SELECT passwd, realName, emailAddress, websiteTitle, websiteUrl, signature, posts, memberGroup, ICQ, AIM, YIM, gender, personalText, avatar, dateRegistered, location, birthdate, timeFormat, timeOffset, hideEmail, ID_MEMBER, memberName, MSN, lngfile FROM {$db_prefix}members WHERE ID_MEMBER='$username' LIMIT 1;") or database_error(__FILE__, __LINE__);
</Search for>

<Replace>
      $request = mysql_query("SELECT passwd, realName, emailAddress, websiteTitle, websiteUrl, signature, posts, memberGroup, ICQ, AIM, YIM, gender, personalText, avatar, dateRegistered, location, birthdate, timeFormat, timeOffset, hideEmail, ID_MEMBER, memberName, MSN, lngfile, showBookmarks FROM {$db_prefix}members WHERE ID_MEMBER='$username' LIMIT 1;") or database_error(__FILE__, __LINE__);
</Replace>


<Edit file>
Sources\Profile.php
</Edit file>

<Search for>
   $request = mysql_query("
      SELECT passwd, realName, emailAddress, websiteTitle, websiteUrl, signature, posts, memberGroup, ICQ, AIM, YIM, gender, personalText, avatar, dateRegistered, location, birthdate, timeFormat, timeOffset, hideEmail, ID_MEMBER, usertitle, karmaBad, karmaGood, lngfile, MSN, secretQuestion, secretAnswer
      FROM {$db_prefix}members
      WHERE memberName='$user'") or database_error(__FILE__, __LINE__);
</Search for>

<Replace>
   $request = mysql_query("
      SELECT passwd, realName, emailAddress, websiteTitle, websiteUrl, signature, posts, memberGroup, ICQ, AIM, YIM, gender, personalText, avatar, dateRegistered, location, birthdate, timeFormat, timeOffset, hideEmail, ID_MEMBER, usertitle, karmaBad, karmaGood, lngfile, MSN, secretQuestion, secretAnswer, showBookmarks
      FROM {$db_prefix}members
      WHERE memberName='$user'") or database_error(__FILE__, __LINE__);
</Replace>

<Search for>
   if ($allow_hide_email)
   {
      $memsettings['hideEmail'] = ($memsettings['hideEmail'] == 1 ? ' checked' : '');
      echo '
                     <tr>
                        <td width="45%"><font size="2"><b>' . $txt[721] . '</b></font></td>
                        <td><input type="checkbox" name="hideemail"' . $memsettings['hideEmail'] . ' /></td>
                     </tr>';
   }
</Search for>

<Add after>
   if ($modSettings['showBookmarks'] == '1')
   {
      $a = ($memsettings['showBookmarks'] == '1') ? ' checked' : '';
      echo '<tr><td width="45%"><font size=2><b>'. $txt['bookmarks18'] .'</b></font></td><td><input type="hidden" name="showBookmarks" value=0><input type="checkbox" name="showBookmarks" value=1' . $a . '></td></tr>';
   }
</Add after>

<Search for>
   global $usertitle, $REMOTE_ADDR, $userpic_width, $userpic_height, $mbname;
</Search for>

<Add after>
   global $showBookmarks;
</Add after>

<Search for>
      $request = mysql_query("
         UPDATE {$db_prefix}members
         SET $queryPasswdPart $customTitlePart realName='$member[name]', emailAddress='$member[email]', websiteTitle='$member[websitetitle]', websiteUrl='$member[websiteurl]', signature='$member[signature]', posts=$member[settings6], memberGroup='$member[settings7]', ICQ='$member[icq]', MSN='$member[msn]', AIM='$member[aim]', YIM='$member[yim]', gender='$member[gender]', personalText='$member[usertext]', avatar='$member[userpic]', $member[dr]location='$member[location]', birthdate='$member[bday]', lngfile='$member[language]', " . ($username == $member['user'] ? "memberIP='$memIP', " : '') . "timeFormat='$member[usertimeformat]', timeOffset=$timeOffest, secretQuestion='$member[secretQuestion]', secretAnswer='$member[secretAnswer]', hideEmail=$hideEmail$karmaStr
         WHERE memberName='$user'") or database_error(__FILE__, __LINE__);
</Search for>

<Replace>
      $request = mysql_query("
         UPDATE {$db_prefix}members
         SET $queryPasswdPart $customTitlePart realName='$member[name]', emailAddress='$member[email]', websiteTitle='$member[websitetitle]', websiteUrl='$member[websiteurl]', signature='$member[signature]', posts=$member[settings6], memberGroup='$member[settings7]', ICQ='$member[icq]', MSN='$member[msn]', AIM='$member[aim]', YIM='$member[yim]', gender='$member[gender]', personalText='$member[usertext]', avatar='$member[userpic]', $member[dr]location='$member[location]', birthdate='$member[bday]', lngfile='$member[language]', " . ($username == $member['user'] ? "memberIP='$memIP', " : '') . "timeFormat='$member[usertimeformat]', timeOffset=$timeOffest, secretQuestion='$member[secretQuestion]', secretAnswer='$member[secretAnswer]', hideEmail=$hideEmail, showBookmarks=$showBookmarks$karmaStr
         WHERE memberName='$user'") or database_error(__FILE__, __LINE__);
</Replace>

<Edit file>
Sources\Subs.php
</Edit file>

<Search for>
function getMemberID($messageID)
{
   global $db_prefix;
   $result = mysql_query("
      SELECT IFNULL(mem.ID_MEMBER,-1) AS ID_MEMBER
      FROM {$db_prefix}messages AS m
         LEFT JOIN {$db_prefix}members AS mem ON (mem.ID_MEMBER=m.ID_MEMBER)
      WHERE m.ID_MSG=$messageID") or database_error(__FILE__, __LINE__);
   if (mysql_num_rows($result) > 0)
   {
      $row = mysql_fetch_array($result);
      return $row['ID_MEMBER'];
   }
   else
      return -1;
}
</Search for>

<Add after>

function yyBookmarks(){
   global $settings, $db_prefix, $ID_MEMBER, $username, $txt, $yytitle, $scripturl, $HTTP_SERVER_VARS, $modSettings;

   $onchange = ' onchange="window.location.href=this.options[this.selectedIndex].value;"';

   if ($username != 'Guest' && $modSettings['showBookmarks'] == '1')
   {
      $sql = "SELECT url, title FROM {$db_prefix}bookmarks WHERE ID_MEMBER = '" . $ID_MEMBER . "' ORDER BY display_order";
      $request = mysql_query ($sql);
      ?>
      <script>
      function addOption(theSel, theText, theValue)
      {
         var newOpt = new Option(theText, theValue);
         var selLength = theSel.length;
         theSel.options[selLength] = newOpt;
      }
      </script>
      <?php
      echo 
'<table border=0 cellspacing=0 cellpadding=0><form name="bookmarkFrm"><tbody><tr><td><b>' $txt['bookmarks1'] . '</b> <select name="bookmarks"'.$onchange.'>';

      while ($row mysql_fetch_assoc($request))
         echo '<option value="' $row['url'] . '">' $row['title'] . '</option>';      

      $addUrl $scripturl '?action=bookmarks;sub=add;title=' urlencode($yytitle) . ';url=' urlencode(urlencode($scripturl.'?'.$HTTP_SERVER_VARS['QUERY_STRING']));

      echo '</select> <input type=button value="' $txt['bookmarks8'] . '" onclick="window.location.href=bookmarks.options[bookmarks.selectedIndex].value;"> <input type=button value="' $txt['bookmarks2'] . '" onclick="window.location.href=\'' $addUrl '\';"> <input type=button value="' $txt['bookmarks3'] . '" onclick="window.open(\'' $scripturl '?action=bookmarks;sub=edit\',\'bookmarks\',\'toolbar=no,location=no,status=no,menubar=no,scrollbars=no,width=500,height=220,resizable=no\');"></td></tr></tbody></form></table>';
  }
}

</
Add after>
Title: Re:[Tested Beta] Bookmarks 1.4.1 and 1.5.0
Post by: Nemesis on April 18, 2003, 03:54:31 AM
Update for 1.5.1 part2:
Code: [Select]
<Edit file>
english.lng
</Edit file>

<Search for>
if ($MenuType == 1)
{
</Search for>

<Add before>

// text entries for the bookmarks mod
$txt['bookmarks1'] = 'Bookmarks: ';
$txt['bookmarks2'] = 'Add';
$txt['bookmarks3'] = 'Edit';
$txt['bookmarks4'] = 'Edit Bookmarks';
$txt['bookmarks5'] = 'To reorder your bookmarks, select the<br />bookmark and use the up and down buttons<br />to move it thoughout the list accordingly.';
$txt['bookmarks6'] = 'Move Up';
$txt['bookmarks7'] = 'Move Down';
$txt['bookmarks8'] = 'Go';
$txt['bookmarks9'] = 'What caption do you want to use?';
$txt['bookmarks10'] = 'My Bookmark';
$txt['bookmarks11'] = 'What is the URL?';
$txt['bookmarks12'] = 'Rename';
$txt['bookmarks13'] = 'Please enter the new name';
$txt['bookmarks14'] = 'Change URL';
$txt['bookmarks15'] = 'Please enter the new URL';
$txt['bookmarks16'] = 'Save Changes';
$txt['bookmarks17'] = 'Cancel';
$txt['bookmarks18'] = 'Enable Bookmarks?';

</Add before>

// This file simply contains replacement code for languages other than english.lng
// We have German, Dutch and Spanish

<Edit file>
german.lng
</Edit file>

<Search for>
if ($MenuType == 1)
{
</Search for>

<Add before>

// text entries for the bookmarks mod
$txt['bookmarks1'] = 'Bookmarks: ';
$txt['bookmarks2'] = 'Hinzufügen';
$txt['bookmarks3'] = 'Editieren';
$txt['bookmarks4'] = 'Editiere Bookmarks';
$txt['bookmarks5'] = 'Zum Umsortieren den<br />Bookmark auswählen und die Aufwärts und Abwärts Buttons benutzen<br />.';
$txt['bookmarks6'] = 'Aufwärts';
$txt['bookmarks7'] = 'Abwärts';
$txt['bookmarks8'] = 'Gehe zu';
$txt['bookmarks9'] = 'Bezeichnung?';
$txt['bookmarks10'] = 'Meine Bookmarks';
$txt['bookmarks11'] = 'URL?';
$txt['bookmarks12'] = 'Umbenennen';
$txt['bookmarks13'] = 'Bitte geben Sie den neuen Namen ein';
$txt['bookmarks14'] = 'URL ändern';
$txt['bookmarks15'] = 'Bitte neue URL eingeben';
$txt['bookmarks16'] = 'Änderungen speichern';
$txt['bookmarks17'] = 'Abbrechen';
$txt['bookmarks18'] = 'Bookmarks aktivieren?';

</Add before>

<Edit file>
dutch.lng
</Edit file>

<Search for>
if ($MenuType == 1)
{
</Search for>

<Add before>

// dutch text entries for the bookmarks mod
$txt['bookmarks1'] = 'Snelkoppelingen: ';
$txt['bookmarks2'] = 'Voeg toe';
$txt['bookmarks3'] = 'Bewerk';
$txt['bookmarks4'] = 'Bewerk snelkoppelingen';
$txt['bookmarks5'] = 'Om je snelkoppelingen te rangschikken, selecteer de<br />snelkoppeling en gebruik de omhoog en omlaag knoppen<br />om deze te verschuiven';
$txt['bookmarks6'] = 'Omhoog';
$txt['bookmarks7'] = 'Omlaag';
$txt['bookmarks8'] = 'Ga';
$txt['bookmarks9'] = 'Welke omschrijving wil je gebruiken?';
$txt['bookmarks10'] = 'Mijn snelkoppeling';
$txt['bookmarks11'] = 'Wat is de URL?';
$txt['bookmarks12'] = 'Hernoem';
$txt['bookmarks13'] = 'Voer de nieuwe naam in';
$txt['bookmarks14'] = 'Verander de URL';
$txt['bookmarks15'] = 'Voer de nieuwe URL in';
$txt['bookmarks16'] = 'Sla de veranderingen op';
$txt['bookmarks17'] = 'Annuleren';
$txt['bookmarks18'] = 'Activeren snelkoppelingen?';

</Add before>

<Edit file>
spanish.lng
</Edit file>

<Search for>
if ($MenuType == 1)
{
</Search for>

<Add before>

// text entries for the bookmarks mod
$txt['bookmarks1'] = 'Bookmarks: ';
$txt['bookmarks2'] = 'Agregar';
$txt['bookmarks3'] = 'Editar';
$txt['bookmarks4'] = 'Editar Bookmarks';
$txt['bookmarks5'] = 'Para reordenar los bookmarks, selecciona el<br />bookmark y usa los botones de arriba y abajo<br />para moverlos a través de la lista.';
$txt['bookmarks6'] = 'Mover Arriba';
$txt['bookmarks7'] = 'Mover Abajo';
$txt['bookmarks8'] = 'Ir';
$txt['bookmarks9'] = '¿Qué mensaje deseas usar?';
$txt['bookmarks10'] = 'Mi Bookmark';
$txt['bookmarks11'] = '¿Cuál es el URL?';
$txt['bookmarks12'] = 'Renombrar';
$txt['bookmarks13'] = 'Por favor introduce el nuevo nombre';
$txt['bookmarks14'] = 'CambiarURL';
$txt['bookmarks15'] = 'Por favor introduce el nuevo URL';
$txt['bookmarks16'] = 'Guardar Cambios';
$txt['bookmarks17'] = 'Cancelar';
$txt['bookmarks18'] = '¿Activar Bookmarks?';

</Add before>
Title: Re:[Tested Beta] Bookmarks 1.4.1 and 1.5.0
Post by: Nemesis on April 18, 2003, 12:00:44 PM
First post Jospeh made now contains an updated mod file, you can simple download and install via boardmod proggy or manually.

Nemey
Title: Re:[Tested Beta] Bookmarks 1.4.1 and 1.5.0
Post by: Wiziwig on April 18, 2003, 11:39:09 PM
Still dont seem to be working right. Db sees the settings, modsettings see the settings, the <tagname> is in template. But, in the index, none of the bookmarks show. When I click on edit, and in the editor select a bookmark from the list, select save, the bookmark appears in the index display. I click on the go button and it takes me to the bookmark, but the bookmark list in the index display disappears again.

Here's the screenshots:

1. Nothing in the index view
http://www.clubmasa.com/debug/bookmark1.jpg

2. Bookmark editor says yes, there is something here.  So lets go and check that and select save
http://www.clubmasa.com/debug/bookmark2.jpg

3. Oh great, good news! now something shows in the index view
http://www.clubmasa.com/debug/bookmark3.jpg

4. No wait, I click on go and the list is gone again!
http://www.clubmasa.com/debug/bookmark4.jpg

Maybe the culprit is in function yyBookmarks(){ of subs.php ??

Title: Re:[Tested Beta] Bookmarks 1.4.1 and 1.5.0
Post by: [Unknown] on April 19, 2003, 12:15:11 AM
After you add it, is it dedicated to the database?

Try adding one with the Add (the one that adds the current page.) button... that work?

-[Unknown]
Title: Re:[Tested Beta] Bookmarks 1.4.1 and 1.5.0
Post by: Wiziwig on April 19, 2003, 12:23:36 AM
yeah, I added. that's how the bookmark got in the edit list.  I even added another one. still the same results.

I go to add/edit/remove or whatever in the editor window and everything appears in the bookmark view list. I go click on the go or click on the home or some other button in the index and the bookmark view list drops everything.

Title: Re:[Tested Beta] Bookmarks 1.4.1 and 1.5.0
Post by: Nemesis on April 19, 2003, 12:29:24 AM
What browser are you using?

It works on my site and horseman...
Title: Re:[Tested Beta] Bookmarks 1.4.1 and 1.5.0
Post by: Wiziwig on April 19, 2003, 12:30:34 AM
Win98SE, IE 6.0.2600

What browser are you using?

It works on my site and horseman...
Title: Re:[Tested Beta] Bookmarks 1.4.1 and 1.5.0
Post by: Nemesis on April 19, 2003, 12:37:15 AM
did you copy the codes from the above file, or dl it from post 1?
Title: Re:[Tested Beta] Bookmarks 1.4.1 and 1.5.0
Post by: Wiziwig on April 19, 2003, 12:44:18 AM
DL from post 1, but I did skim over the posted code and it appears that function yyBookmarks() in subs is the same for both.

did you copy the codes from the above file, or dl it from post 1?
Title: Re:[Tested Beta] Bookmarks 1.4.1 and 1.5.0
Post by: Nemesis on April 19, 2003, 12:49:23 AM
try this: (replaces the yyfunction before and after including bookmark function. This is straight from the subs.php i am using live.

Code: [Select]
function getMemberID($messageID)
{
   global $db_prefix;
   $result = mysql_query("
      SELECT IFNULL(mem.ID_MEMBER,-1) AS ID_MEMBER
      FROM {$db_prefix}messages AS m
         LEFT JOIN {$db_prefix}members AS mem ON (mem.ID_MEMBER=m.ID_MEMBER)
      WHERE m.ID_MSG=$messageID") or database_error(__FILE__, __LINE__);
   if (mysql_num_rows($result) > 0)
   {
      $row = mysql_fetch_array($result);
      return $row['ID_MEMBER'];
   }
   else
      return -1;
}

function yyBookmarks(){
   global $settings, $db_prefix, $ID_MEMBER, $username, $txt, $yytitle, $scripturl, $HTTP_SERVER_VARS, $modSettings;

   $onchange = ' onchange="window.location.href=this.options[this.selectedIndex].value;"';

   if ($username != 'Guest' && $modSettings['showBookmarks'] == '1')
   {
      $sql = "SELECT url, title FROM {$db_prefix}bookmarks WHERE ID_MEMBER = '" . $ID_MEMBER . "' ORDER BY display_order";
      $request = mysql_query ($sql);
      ?>
      <script>
      function addOption(theSel, theText, theValue)
      {
         var newOpt = new Option(theText, theValue);
         var selLength = theSel.length;
         theSel.options[selLength] = newOpt;
      }
      </script>
      <?php
      
echo '<table border=0 cellspacing=0 cellpadding=0><form name="bookmarkFrm"><tbody><tr><td><b>' $txt['bookmarks1'] . '</b> <select name="bookmarks"'.$onchange.'>';

      while (
$row mysql_fetch_assoc($request))
         echo 
'<option value="' $row['url'] . '">' $row['title'] . '</option>';      

      
$addUrl $scripturl '?action=bookmarks;sub=add;title=' urlencode($yytitle) . ';url=' urlencode(urlencode($scripturl.'?'.$HTTP_SERVER_VARS['QUERY_STRING']));

      echo 
'</select> <input type=button value="' $txt['bookmarks8'] . '" onclick="window.location.href=bookmarks.options[bookmarks.selectedIndex].value;"> <input type=button value="' $txt['bookmarks2'] . '" onclick="window.location.href=\'' $addUrl '\';"> <input type=button value="' $txt['bookmarks3'] . '" onclick="window.open(\'' $scripturl '?action=bookmarks;sub=edit\',\'bookmarks\',\'toolbar=no,location=no,status=no,menubar=no,scrollbars=no,width=500,height=220,resizable=no\');"></td></tr></tbody></form></table>';
  }
}

function 
un_html_entities ($string)
{
   
$trans_tbl get_html_translation_table (HTML_ENTITIES);
   
$trans_tbl array_flip ($trans_tbl);
   
$trans_tbl['&#039;'] = "'";
   return 
strtr ($string$trans_tbl);
}
Title: Re:[Tested Beta] Bookmarks 1.4.1 and 1.5.0
Post by: Wiziwig on April 19, 2003, 12:53:43 AM
I must of been wrong about what the mod has for function yyBookmarks() and what you posted, I copied/pasted over function yyBookmarks() your posting for it and it now works. Somebody outa change that archive file maybe?
Title: Re:[Tested Beta] Bookmarks 1.4.1 and 1.5.0
Post by: Nemesis on April 19, 2003, 12:57:24 AM
I will, weird....
Title: Re:[Tested Beta] Bookmarks 1.4.1 and 1.5.0
Post by: Nemesis on April 19, 2003, 01:01:14 AM
Okay I updated the mod file and re-uploaded to yabbse.

If anyone has any problems still, just do the same as I had Wizwig do a couple post up...
Title: Re:[Tested Beta] Bookmarks 1.4.1 and 1.5.0
Post by: Wiziwig on April 19, 2003, 01:07:44 AM
it's a smart mod nem. may I ask can I have permission to add this to Supermod ?? :)
Title: Re:[Tested Beta] Bookmarks 1.4.1 and 1.5.0
Post by: Nemesis on April 19, 2003, 01:14:39 AM
I wish I could give you permission but it is really Joseph mod, I just updated it to work with 1.5.1

I am sure if you IM him he won't mind.

 ;D
Title: Re:[Tested Beta] Bookmarks 1.4.1 and 1.5.0
Post by: Wiziwig on April 19, 2003, 10:33:21 AM
Another bug to report. If admin has enabled bookmarks, and user disables bookmarks in profile, bookmarks show regardless.

Title: Re:[Tested Beta] Bookmarks 1.4.1 and 1.5.0
Post by: Horseman on April 19, 2003, 11:02:13 AM
this is in subs.php, function bookmarks()

Code: [Select]
<search for>
function yyBookmarks(){
   global $settings, $db_prefix, $ID_MEMBER, $username, $txt, $yytitle, $boardurl, $HTTP_SERVER_VARS, $modSettings;

   $onchange = ' onchange="window.location.href=this.options[this.selectedIndex].value;"';

   if ($username != 'Guest' && $modSettings['showBookmarks'] == '1')
   {
      $sql = "SELECT url, title FROM {$db_prefix}bookmarks WHERE ID_MEMBER = '" . $ID_MEMBER . "' ORDER BY display_order";
      $request = mysql_query ($sql);
      ?>
      <script>
      function addOption(theSel, theText, theValue)
      {
         var newOpt = new Option(theText, theValue);
         var selLength = theSel.length;
         theSel.options[selLength] = newOpt;
      }
      </script>
      <?php
      
echo '<table border=0 cellspacing=0 cellpadding=0><form name="bookmarkFrm"><tbody><tr><td><b>' $txt['bookmarks1'] . '</b> <select name="bookmarks"'.$onchange.'>';

      while (
$row mysql_fetch_assoc($request))
         echo 
'<option value="' $row['url'] . '">' $row['title'] . '</option>';     

      
$addUrl $boardurl '?action=bookmarks;sub=add;title=' urlencode($yytitle) . ';url=' urlencode(urlencode($boardurl.'?'.$HTTP_SERVER_VARS['QUERY_STRING']));

      echo 
'</select> <input type=button value="' $txt['bookmarks8'] . '" onclick="window.location.href=bookmarks.options[bookmarks.selectedIndex].value;"> <input type=button value="' $txt['bookmarks2'] . '" onclick="window.location.href=\'' $addUrl '\';"> <input type=button value="' $txt['bookmarks3'] . '" onclick="window.open(\'' $boardurl '?action=bookmarks;sub=edit\',\'bookmarks\',\'toolbar=no,location=no,status=no,menubar=no,scrollbars=no,width=500,height=220,resizable=no\');"></td></tr></tbody></form></table>';
  }
}
</
search for>

<
replace>
function 
yyBookmarks(){
  global 
$settings$db_prefix$ID_MEMBER$username$txt$yytitle$scripturl$HTTP_SERVER_VARS$modSettings;

  
$onchange ' onchange="window.location.href=this.options[this.selectedIndex].value;"';

   if (
$username != 'Guest' && $modSettings['showBookmarks'] == '1')
   {
   
$request mysql_query("
      SELECT ID_MEMBER, showBookmarks
      FROM 
{$db_prefix}members
      WHERE ID_MEMBER='
$ID_MEMBER'") or database_error(__FILE____LINE__);
      
$memsettings mysql_fetch_array($request);

      if (
$memsettings['showBookmarks'] == '1')
      {
         
$sql "SELECT url, title FROM {$db_prefix}bookmarks WHERE ID_MEMBER = '" $ID_MEMBER "' ORDER BY display_order";
         
$request mysql_query ($sql);
         
?>

               <script>
               function addOption(theSel, theText, theValue)
         {
            var newOpt = new Option(theText, theValue);
            var selLength = theSel.length;
            theSel.options[selLength] = newOpt;
         }  
         </script>
         <?php
         
echo '<table border=0 cellspacing=0 cellpadding=0><form name="bookmarkFrm"><tbody><tr><td><b>' $txt['bookmarks1'] . '</b> <select name="bookmarks"'.$onchange.'>';
         while (
$row mysql_fetch_assoc($request))
         echo 
'<option value="' $row['url'] . '">' $row['title'] . '</option>';   
         
$addUrl $boardurl '?action=bookmarks;sub=add;title=' urlencode($yytitle) . ';url=' urlencode(urlencode($boardurl.'?'.$HTTP_SERVER_VARS['QUERY_STRING']));
         echo 
'</select> <input type=button value="' $txt['bookmarks8'] . '" onclick="window.location.href=bookmarks.options[bookmarks.selectedIndex].value;"> <input type=button value="' $txt['bookmarks2'] . '" onclick="window.location.href=\'' $addUrl '\';"> <input type=button value="' $txt['bookmarks3'] . '" onclick="window.open(\'' $boardurl '?action=bookmarks;sub=edit\',\'bookmarks\',\'toolbar=no,location=no,status=no,menubar=no,scrollbars=no,width=500,height=220,resizable=no\');"></td></tr></tbody></form></table>';
      }
   }   
}
</
replace>
Title: Re:[Tested Beta] Bookmarks 1.4.1 and 1.5.0
Post by: Nemesis on April 19, 2003, 11:05:51 AM
Or just download the file again, i have updated it.

 ;D

Thanks Horseman!
Title: Re:[Tested Beta] Bookmarks 1.4.1 and 1.5.0
Post by: Nemesis on April 19, 2003, 11:45:43 AM
re-updated the zip file again.  ;D
Title: Re:[Tested Beta] Bookmarks 1.4.1 and 1.5.0
Post by: Jack.R.Abbit on April 20, 2003, 05:44:03 PM
I know no one really gives a crap about Opera browser, but I just that I would point out that it does not work in Opera but it is because of some "not so correct" JavaScript.  Things would work much better if you make any references to form elements by first nameing the form... for instance... to refer to the "bookmarks" select you should refer to it as "form1.bookmarks"  doing this will make it more correct and work for browser that require standards to be followed.

Also, bookmarks.php produces an html page that does not have a closing "head" tag... nothing major but an error just the same.

-Jack
Title: Re:[Tested Beta] Bookmarks 1.4.1 and 1.5.0
Post by: CokeCan on May 05, 2003, 06:02:02 PM
If I, or any user, uncheck the "Enable Bookmarks?" I keep on seeing the Bookmarks :-\
Can someone please help me?
Thanks in advanced!
Title: Re:[Tested Beta] Bookmarks 1.4.1 and 1.5.0
Post by: Tilton53 on May 06, 2003, 11:20:16 AM
Ok thanx for the updates guys it fixed the problem I was having!    ;D
Title: Re:[Tested Beta] Bookmarks 1.4.1 and 1.5.0
Post by: CokeCan on May 06, 2003, 11:40:38 AM
I had to do the changes that Nemesis posted but none can turn off the bookmarks :-\
Does anybody can help me?

Thanks in advanced!
Title: Re:[Tested Beta] Bookmarks 1.4.1 and 1.5.0
Post by: Fizzy on May 12, 2003, 05:35:42 PM
I tried this with 1.5.1 RC1 and it logged me out - wouldn't let me log back in either  ::)

Binned.
Title: Re:[Tested Beta] Bookmarks 1.4.1 and 1.5.0
Post by: Norbert on May 18, 2003, 04:09:20 PM
The mod is great. I would like to have the option for the admin that he can make bookmarks which members can't delete.
Title: Re:[Tested Beta] Bookmarks 1.4.1 and 1.5.0
Post by: Bell1x1 on June 03, 2003, 12:15:18 AM
Love this mod. Will it work with 1.5.3?
Title: Re:[Tested Beta] Bookmarks 1.4.1 and 1.5.0
Post by: Nemesis on June 03, 2003, 04:29:02 PM
Love this mod. Will it work with 1.5.3?

yep but currently it don't work with opera/mozilla browsers to well for external links.

I was working on fixing it but got caught in other projects.

Nemey
Title: Re:[Tested Beta] Bookmarks 1.4.1 and 1.5.0
Post by: Bell1x1 on June 04, 2003, 10:58:35 AM
Phew...I just did the mod with Smileys, Allowed User, and User Color (in that order) I had to manually make some changes because of the User Color mod, but everything uploaded and seemed to work fine until I went to add a page to my bookmarks.

It added in the database, but never showed on my index.php.

I even removed the User Color mod (Back up files) and tried then. It installed perfectly, yet still had the same problem. If you click the add button, it doesn't show in your bookmarks (only if you choose to edit your bookmarks, then it shows).

As mich as I like a challenge, I don't see the point in trying to figure this one out. I read through these posts and have come to the conclusion that I will wait for the final version to come out.
Title: Re:[Tested Beta] Bookmarks 1.4.1 and 1.5.0
Post by: Darkknight550 on June 06, 2003, 02:18:21 AM
I also installed this mod and it logged me and all members out. I nor my members can not log back in. I've tried my backup username but no go.
Title: Re:[Tested Beta] Bookmarks 1.4.1 and 1.5.0
Post by: Nemesis on June 06, 2003, 03:53:36 AM
Maybe cause it hasn't been update to work with 1.5.3

I'll try and update it tommorrow if I have some time.

Nemey
Title: Re:[Tested Beta] Bookmarks 1.4.1 and 1.5.0
Post by: GWP on June 12, 2003, 01:16:52 PM
Has anyone tried to delete some bookmarks.
Even the bookmark on this forum doesn't do it.

They just keep coming back??
Title: Re:[Tested Beta] Bookmarks 1.4.1 and 1.5.0
Post by: oldiesmann on June 12, 2003, 10:39:10 PM
I tried installing this mod and got a bunch of errors about cannot modify header information. Gotta go uninstall it and try to figure out what the heck caused that error.
Title: Re:[Tested Beta] Bookmarks 1.4.1 and 1.5.0
Post by: oldiesmann on June 12, 2003, 11:03:44 PM
Ok... I uninstalled everything, and overwrote subs.php with itself (ie I copied the stuff from subs.php to notepad and then pasted it back into subs.php), and it fixed the errors. I'm gonna try it again and see what happens.
Title: Re:[Tested Beta] Bookmarks 1.4.1 and 1.5.0
Post by: oldiesmann on June 14, 2003, 03:54:26 PM
Fixed the errors - Net2FTP's software always adds a blank line at the end of the file (after the last line) when you use their online file editor, so if you don't delete the extra line each time, it adds another one, and that causes problems apparently. Anyway, after installing it and replacing the code with Nemisis' fix, it works great! Getting it on the same line as the moods from my moods mod was a bit tricky, but I got it to work... Basically, I did this:

Code: [Select]
<table width="90%" align="center" cellspacing="0" cellpadding="0">
    <tr>
        <td align="left" colspan="3" valign="middle"><yabb mood></td>
        <td align="right" colspan="3" valign="middle"><yabb bookmarks></td>
    </tr>
</table>

If you need help getting it to display properly in your template, let me know and I'll see what I can do for you. I ended the first table after the </tr> following the <yymenu> tag in my template, then inserted that table above and created another table tag to display the rest of the info...
Title: Re:[Tested Beta] Bookmarks 1.4.1 and 1.5.0
Post by: Curbow 5 on July 08, 2003, 08:55:21 AM
Still dont seem to be working right. Db sees the settings, modsettings see the settings, the <tagname> is in template. But, in the index, none of the bookmarks show. When I click on edit, and in the editor select a bookmark from the list, select save, the bookmark appears in the index display. I click on the go button and it takes me to the bookmark, but the bookmark list in the index display disappears again.
I had the same problem upon installing today... Eventually I found out there's a typo in the updated 151 mod file Nemesis uploaded!

search for the following line which is to be added to Subs.php:
echo 'option value="' . $row['url'] . '">' . $row['title'] . '</option>';
and replace it with:
echo '<option value="' . $row['url'] . '">' . $row['title'] . '</option>';

works like a charm now! could someone please correct the typo in the zipfile? thanks!  :)
Title: Re:[Tested Beta] Bookmarks 1.4.1 and 1.5.0
Post by: LeeCDVM on July 22, 2003, 10:04:19 AM
Is the .zip file for teh bookmarks MOD updated yet or is it still needing to have some work done to it?

thanks in advance ...

Doc
Title: Re:[Tested Beta] Bookmarks 1.4.1 and 1.5.0
Post by: Spaceman-Spiff on July 22, 2003, 10:06:32 AM
the current bookmark in this forum is not editable
the 'save changes' button won't do anything in non-ie browsers
has this been fixed yet?
Title: Re:[Tested Beta] Bookmarks 1.4.1 and 1.5.0
Post by: Cerberus on October 11, 2003, 03:01:03 PM
If you click the add button, it doesn't show in your bookmarks (only if you choose to edit your bookmarks, then it shows).

Same here :( (ultra-modded pfabb)
Title: Re:[Tested Beta] Bookmarks 1.4.1 and 1.5.0
Post by: Cerberus on October 11, 2003, 03:02:03 PM
Quote
search for the following line which is to be added to Subs.php:
echo 'option value="' . $row['url'] . '">' . $row['title'] . '</option>';
and replace it with:
echo '<option value="' . $row['url'] . '">' . $row['title'] . '</option>';

works like a charm now! could someone please correct the typo in the zipfile? thanks!  :)
Great! You're da man :)

btw: the file hasn't been updated :(