[BETA] Avatar resize fix

[Chris Cromer]

 

There is another way to do it without using size all the time, just store the size on the database when they change the profile. Then get the size from the members table instead of calling that command repeadidly which will slow it down.

[itswheelie]

hey, maybe Chris, REL and Dude can get together and between them make THE best mod.

seems to me that each of the existing mods has something going for them, add Chris' comments and between the three come up with the best result

Just my 2 cents worth.

[David]

As I think Joseph pointed out, if you check the size when saving profile then someone could upload a new image with the same name and its size would never be checked.

[Ben_S]

true but most wouldnt, and if they do it just to be a pint you can always ban then

[David]

The next solution from the beta thread is in the profile you record the image size and then use that size when displaying it.  So if they change the image it will still be the correct size.

[Hypocrite]

The next solution from the beta thread is in the profile you record the image size and then use that size when displaying it.  So if they change the image it will still be the correct size.

That would be the best option in my opinion

[David]

The next solution from the beta thread is in the profile you record the image size and then use that size when displaying it.  So if they change the image it will still be the correct size.

That would be the best option in my opinion

Just read a few posts earlier in this thread and it seems Chris actually suggessted this.  

[Chris Cromer]

Hehe...

[Hypocrite]

LOL...

[Nemesis]

This will remain a mod and a mod only. Sorry I will not package this in 1.4.1.

There are several reasons to this.
1.) I just want to get the package released.
2.)There are performance issues with resizing avatars. That has been talked about already on the beta boards. (*Sorry* you don't have access to those boards.)

If this mod progress to a really good mod with ideas that was stated. Maybe it will make it into YaBB SE 2

Who knows?  

[vegatopia]

I have a problem with this one. It seemed to work oké, but it gave an error on anyone viewing their profile. On the top of the profile-page it says:

Code Select Expand

Parse error: parse error, unexpected '>' in /opt/guide/HTML/forum/Sources/Profile.php on line 885

Fatal error: Call to undefined function: viewprofile() in /opt/guide/HTML/forum/index.php on line 382


[Tenkoy]

Okay, I found this mod made by REL, the avatar resize fix. I found it at Wizwig's ftp.

ftp://ftp.clubmasa.com/

I tested this mod and found that this mod works with 1.5.1 RC38. But, it seems to have a problem with resizing jpegs. It can resize gifs just fine.

It has one quirk, it won't allow you to put in the url to jpegs that are too large, first you have to upload a small jpeg to your webspace, and then set your avatar to that, and then you have to go back to your webspace and replace that image with the larger one you wish to use. The only way to use larger jpegs so far seems to be to pull a switch-a-roo on it.

[TF]

Its something wrong with this mod.

I got this under the pics which is over the size in Forum Preferences:

" width="60" height="60" border="0" alt="">


Whats wrong??

Can someone take a look at this code, Load.php. This is the replace-code:

Code Select Expand


<replace>
      $userprofile[$user]['avatar'] = ($userprofile[$user]['avatar']=='') ? 'blank.gif' : "{$userprofile[$user]['avatar']}";
      $tmp = stristr($userprofile[$user]['avatar'],'http://') ? "{$userprofile[$user]['avatar']}" : "$facesurl/{$userprofile[$user]['avatar']}";
      $size = @getimagesize ($tmp);
      if ($size[0]>$userpic_width or $size[1]>$userpic_height) {
         if ($size[1]>$userpic_height) {
            $userprofile[$user]['avatar'] = stristr("{$userprofile[$user]['avatar']}",'http://') ? "<br><img src=\"{$userprofile[$user]['avatar']}\" width=$size[0] $userpic_tmpheight border=\"0\" alt=\"\"><br><br>" : "<br><img src=\"$facesurl/{$userprofile[$user]['avatar']}\" border=\"0\" alt=\"\"><br><br>";
         } elseif ($size[0]>$userpic_width) {
            $userprofile[$user]['avatar'] = stristr("{$userprofile[$user]['avatar']}",'http://') ? "<br><img src=\"{$userprofile[$user]['avatar']}\"$userpic_tmpwidth height=$size[1] border=\"0\" alt=\"\"><br><br>" : "<br><img src=\"$facesurl/{$userprofile[$user]['avatar']}\" border=\"0\" alt=\"\"><br><br>";
         }
         if ($size[0]>$userpic_width and $size[1]>$userpic_height) {
            $userprofile[$user]['avatar'] = stristr("{$userprofile[$user]['avatar']}",'http://') ? "<br><img src=\"{$userprofile[$user]['avatar']}\"$userpic_tmpwidth$userpic_tmpheight border=\"0\" alt=\"\"><br><br>" : "<br><img src=\"$facesurl/{$userprofile[$user]['avatar']}\" border=\"0\" alt=\"\"><br><br>";
         }
      } else {
         $userprofile[$user]['avatar'] = stristr("{$userprofile[$user]['avatar']}",'http://') ? "<br><img src=\"{$userprofile[$user]['avatar']}\" $size[3] border=\"0\" alt=\"\"><br><br>" : "<br><img src=\"$facesurl/{$userprofile[$user]['avatar']}\" border=\"0\" alt=\"\"><br><br>";
      }
</replace>




[TF]

Please help...      

[Tenkoy]

Okay, the avatar resize mod at wizwig's forum works great, you just have to make one little change to have it work perfectly.

In Profile.php, find this part.

Code Select Expand

      // now let's validate the avatar
      $sizes = @getimagesize($member['userpic']);
      if ($sizes && (($sizes[0] > $userpic_width && $userpic_width != 0) || ($sizes[1] > $userpic_height && $userpic_height != 0)))
         fatal_error("$txt[yse227]  $userpic_width x $userpic_height)");

And comment it out as such:

Code Select Expand

      // now let's validate the avatar
      //$sizes = @getimagesize($member['userpic']);
      //if ($sizes && (($sizes[0] > $userpic_width && $userpic_width != 0) || ($sizes[1] > $userpic_height && $userpic_height != 0)))
         //fatal_error("$txt[yse227]  $userpic_width x $userpic_height)");

.....or you could simply remove it, whichever one you want to do.

This will stop it from spitting out the too large message for jpeg images and simply resize it like a good little boy. The avatar will be resized to whatever you want, plus it will not be affected if it's not larger than the limit.


Confirmed to work with 1.5.1 RC45 with that simple change I pointed out above.