[Done] Online Time Mod [v0.3a]

[Surfy]

i have the German mod installed, works well  


very well  

Surfy

[BiErLeEuW]

download links are dead... can somebody upload him again?

[Spaceman-Spiff]

since vory isnt reponding to my IM and emails,
i'll try to upgrade the mod when i can find the time

[BiErLeEuW]

tnx and i hope it's working with your more stats mod!

[BiErLeEuW]

since vory isnt reponding to my IM and emails,
i'll try to upgrade the mod when i can find the time

I am still waiting for u Master of the YaBB Mods Like to intergrade him in your More stats mod

[Thomas]

I am looking forward to this too. Does anyone know if it is implemented in SMF?

/Thomas

[Shadow's Pawn]

I am looking forward to this too. Does anyone know if it is implemented in SMF?

/Thomas

Yes, it is.  Go to the SMF site and you'll see that they count time online in your profile.

As for this mod...  I got it installed and no errors occur, however it does not seem to be counting the time.  Anyone else have this problem?  It might be because I'm running Enigma, but I don't think that the WriteLog function is different than in a normal YaBB SE installation.

Hopefully I can figure this out...

[Shadow's Pawn]

Well I narrowed the problem down a little bit.  The problem is, this thing seems incapable of figuring out what $lengthTime should be.

Here is the code:

Code Select Expand


      $result = mysql_fetch_array($request);
      if ($result != false)
      {
         $lengthTime = $logTime - $result[0];
         if ($lengthTime < 900)
            $request = mysql_query ("
               UPDATE {$db_prefix}members
               SET onlineTime=onlineTime+$lengthTime
               WHERE ID_MEMBER=$ID_MEMBER");


It appears as though the dumb thing is subtracting the same number from itself, which is resulting in 0, so it's not adding the time.

I don't know how to do this.  I'm going to try to figure it out but if anyone can drop me a hint, that would be great.

[dvucko]

Well I narrowed the problem down a little bit.  The problem is, this thing seems incapable of figuring out what $lengthTime should be.

Here is the code:

Code Select Expand


      $result = mysql_fetch_array($request);
      if ($result != false)
      {
         $lengthTime = $logTime - $result[0];
         if ($lengthTime < 900)
            $request = mysql_query ("
               UPDATE {$db_prefix}members
               SET onlineTime=onlineTime+$lengthTime
               WHERE ID_MEMBER=$ID_MEMBER");


It appears as though the dumb thing is subtracting the same number from itself, which is resulting in 0, so it's not adding the time.

I don't know how to do this.  I'm going to try to figure it out but if anyone can drop me a hint, that would be great.

Use this (YaBBSE 1.5.4 / PfaBB 0.7)!  

Code Select Expand

function WriteLog ()
{
   global $REMOTE_ADDR, $username, $db_prefix, $ID_MEMBER, $QUERY_STRING;

   $logTime = time();

   if ($ID_MEMBER == -1 && !empty($REMOTE_ADDR) && ip2long($REMOTE_ADDR) != -1)
   {
      $request = mysql_query ("
         DELETE FROM {$db_prefix}log_online
         WHERE logTime < " . ($logTime - 900) . "
            OR identity=IFNULL(INET_ATON('$REMOTE_ADDR'), -1)") or database_error(__FILE__, __LINE__);
      $request = mysql_query ("
         REPLACE INTO {$db_prefix}log_online
            (identity, logTime, url, ip)
         VALUES (IFNULL(INET_ATON('$REMOTE_ADDR'), -1), $logTime, '$QUERY_STRING', '$REMOTE_ADDR')") or database_error(__FILE__, __LINE__);
   }
   else
   {
      if (!is_numeric($ID_MEMBER))
         $ID_MEMBER = -1;
      //--- dodatek za online time
      $request = mysql_query("SELECT logTime FROM {$db_prefix}log_online WHERE identity='$ID_MEMBER'");
      $result = mysql_fetch_array($request);
      if ($result != false) {
         $lengthTime = $logTime - $result[0];
         if ($lengthTime < 900) $request = mysql_query ("UPDATE {$db_prefix}members SET onlineTime=onlineTime+$lengthTime WHERE ID_MEMBER=".$GLOBALS[ID_MEMBER]);
      }
      //---
      $request = mysql_query ("
         DELETE FROM {$db_prefix}log_online
         WHERE logTime < " . ($logTime - 900) . "
            OR identity=$ID_MEMBER") or database_error(__FILE__, __LINE__);
      $request = mysql_query ("
         REPLACE INTO {$db_prefix}log_online
            (identity, logTime, url, ip)
         VALUES ($ID_MEMBER, $logTime, '$QUERY_STRING', '$REMOTE_ADDR')") or database_error(__FILE__, __LINE__);

   }
}

[Shadow's Pawn]

That seems to work perfectly.  Thank you.

[bluesyrio]

Yep I should of done that.. interesting how well meaning actions have helped you find a serious flaw with how yabbse is handling these type of posts..

Yep, we have noticed this problema in our board quite a long time ago. And it's quite annoying...  

[r0Nk0Ne]

Can nobody put a link? plz