Welcome, Guest. Please Login or Register.
September 16, 2021, 06:29:18 AM
Home Help Search Login Register
News: SMF is the next generation in forum software, almost completely re-written from the ground up, make sure you don't fall for cheap imitations that suffer from feature bloat!

YaBB SE Community  |  Development  |  Completed mods  |  Topic: [Tested BETA] Bookmarks 1.4.1 and 1.5.0 « previous next »
Pages: 1 2 3 [4] 5 6 Reply Ignore Print
Author Topic: [Tested BETA] Bookmarks 1.4.1 and 1.5.0  (Read 14621 times)
[Unknown]
Global Moderator
YaBB God
*****
Posts: 7830



WWW
Re:[Tested Beta] Bookmarks 1.4.1 and 1.5.0
« Reply #45 on: April 19, 2003, 12:15:11 AM »
Reply with quote

After you add it, is it dedicated to the database?

Try adding one with the Add (the one that adds the current page.) button... that work?

-[Unknown]
Logged
Wiziwig
Sr. Member
****
Posts: 407


Programmer and Users Liason and Manager


WWW
Re:[Tested Beta] Bookmarks 1.4.1 and 1.5.0
« Reply #46 on: April 19, 2003, 12:23:36 AM »
Reply with quote

yeah, I added. that's how the bookmark got in the edit list.  I even added another one. still the same results.

I go to add/edit/remove or whatever in the editor window and everything appears in the bookmark view list. I go click on the go or click on the home or some other button in the index and the bookmark view list drops everything.

« Last Edit: April 19, 2003, 12:28:50 AM by Wiziwig » Logged

Nemesis
What's an Admin?
Global Moderator
YaBB God
*****
Posts: 2199



WWW
Re:[Tested Beta] Bookmarks 1.4.1 and 1.5.0
« Reply #47 on: April 19, 2003, 12:29:24 AM »
Reply with quote

What browser are you using?

It works on my site and horseman...
Logged


Want to say thanks?
*************************************
DONATE or check out my WishList
*********************************
Wiziwig
Sr. Member
****
Posts: 407


Programmer and Users Liason and Manager


WWW
Re:[Tested Beta] Bookmarks 1.4.1 and 1.5.0
« Reply #48 on: April 19, 2003, 12:30:34 AM »
Reply with quote

Win98SE, IE 6.0.2600

What browser are you using?

It works on my site and horseman...
Logged

Nemesis
What's an Admin?
Global Moderator
YaBB God
*****
Posts: 2199



WWW
Re:[Tested Beta] Bookmarks 1.4.1 and 1.5.0
« Reply #49 on: April 19, 2003, 12:37:15 AM »
Reply with quote

did you copy the codes from the above file, or dl it from post 1?
Logged


Want to say thanks?
*************************************
DONATE or check out my WishList
*********************************
Wiziwig
Sr. Member
****
Posts: 407


Programmer and Users Liason and Manager


WWW
Re:[Tested Beta] Bookmarks 1.4.1 and 1.5.0
« Reply #50 on: April 19, 2003, 12:44:18 AM »
Reply with quote

DL from post 1, but I did skim over the posted code and it appears that function yyBookmarks() in subs is the same for both.

did you copy the codes from the above file, or dl it from post 1?
Logged

Nemesis
What's an Admin?
Global Moderator
YaBB God
*****
Posts: 2199



WWW
Re:[Tested Beta] Bookmarks 1.4.1 and 1.5.0
« Reply #51 on: April 19, 2003, 12:49:23 AM »
Reply with quote

try this: (replaces the yyfunction before and after including bookmark function. This is straight from the subs.php i am using live.

Code: [Select]
function getMemberID($messageID)
{
   global $db_prefix;
   $result = mysql_query("
      SELECT IFNULL(mem.ID_MEMBER,-1) AS ID_MEMBER
      FROM {$db_prefix}messages AS m
         LEFT JOIN {$db_prefix}members AS mem ON (mem.ID_MEMBER=m.ID_MEMBER)
      WHERE m.ID_MSG=$messageID") or database_error(__FILE__, __LINE__);
   if (mysql_num_rows($result) > 0)
   {
      $row = mysql_fetch_array($result);
      return $row['ID_MEMBER'];
   }
   else
      return -1;
}

function yyBookmarks(){
   global $settings, $db_prefix, $ID_MEMBER, $username, $txt, $yytitle, $scripturl, $HTTP_SERVER_VARS, $modSettings;

   $onchange = ' onchange="window.location.href=this.options[this.selectedIndex].value;"';

   if ($username != 'Guest' && $modSettings['showBookmarks'] == '1')
   {
      $sql = "SELECT url, title FROM {$db_prefix}bookmarks WHERE ID_MEMBER = '" . $ID_MEMBER . "' ORDER BY display_order";
      $request = mysql_query ($sql);
      ?>
      <script>
      function addOption(theSel, theText, theValue)
      {
         var newOpt = new Option(theText, theValue);
         var selLength = theSel.length;
         theSel.options[selLength] = newOpt;
      }
      </script>
      <?php
      
echo '<table border=0 cellspacing=0 cellpadding=0><form name="bookmarkFrm"><tbody><tr><td><b>' $txt['bookmarks1'] . '</b> <select name="bookmarks"'.$onchange.'>';

      while (
$row mysql_fetch_assoc($request))
         echo 
'<option value="' $row['url'] . '">' $row['title'] . '</option>';      

      
$addUrl $scripturl '?action=bookmarks;sub=add;title=' urlencode($yytitle) . ';url=' urlencode(urlencode($scripturl.'?'.$HTTP_SERVER_VARS['QUERY_STRING']));

      echo 
'</select> <input type=button value="' $txt['bookmarks8'] . '" onclick="window.location.href=bookmarks.options[bookmarks.selectedIndex].value;"> <input type=button value="' $txt['bookmarks2'] . '" onclick="window.location.href=\'' $addUrl '\';"> <input type=button value="' $txt['bookmarks3'] . '" onclick="window.open(\'' $scripturl '?action=bookmarks;sub=edit\',\'bookmarks\',\'toolbar=no,location=no,status=no,menubar=no,scrollbars=no,width=500,height=220,resizable=no\');"></td></tr></tbody></form></table>';
  }
}

function 
un_html_entities ($string)
{
   
$trans_tbl get_html_translation_table (HTML_ENTITIES);
   
$trans_tbl array_flip ($trans_tbl);
   
$trans_tbl['&#039;'] = "'";
   return 
strtr ($string$trans_tbl);
}
Logged


Want to say thanks?
*************************************
DONATE or check out my WishList
*********************************
Wiziwig
Sr. Member
****
Posts: 407


Programmer and Users Liason and Manager


WWW
Re:[Tested Beta] Bookmarks 1.4.1 and 1.5.0
« Reply #52 on: April 19, 2003, 12:53:43 AM »
Reply with quote

I must of been wrong about what the mod has for function yyBookmarks() and what you posted, I copied/pasted over function yyBookmarks() your posting for it and it now works. Somebody outa change that archive file maybe?
Logged

Nemesis
What's an Admin?
Global Moderator
YaBB God
*****
Posts: 2199



WWW
Re:[Tested Beta] Bookmarks 1.4.1 and 1.5.0
« Reply #53 on: April 19, 2003, 12:57:24 AM »
Reply with quote

I will, weird....
Logged


Want to say thanks?
*************************************
DONATE or check out my WishList
*********************************
Nemesis
What's an Admin?
Global Moderator
YaBB God
*****
Posts: 2199



WWW
Re:[Tested Beta] Bookmarks 1.4.1 and 1.5.0
« Reply #54 on: April 19, 2003, 01:01:14 AM »
Reply with quote

Okay I updated the mod file and re-uploaded to yabbse.

If anyone has any problems still, just do the same as I had Wizwig do a couple post up...
Logged


Want to say thanks?
*************************************
DONATE or check out my WishList
*********************************
Wiziwig
Sr. Member
****
Posts: 407


Programmer and Users Liason and Manager


WWW
Re:[Tested Beta] Bookmarks 1.4.1 and 1.5.0
« Reply #55 on: April 19, 2003, 01:07:44 AM »
Reply with quote

it's a smart mod nem. may I ask can I have permission to add this to Supermod ?? :)
Logged

Nemesis
What's an Admin?
Global Moderator
YaBB God
*****
Posts: 2199



WWW
Re:[Tested Beta] Bookmarks 1.4.1 and 1.5.0
« Reply #56 on: April 19, 2003, 01:14:39 AM »
Reply with quote

I wish I could give you permission but it is really Joseph mod, I just updated it to work with 1.5.1

I am sure if you IM him he won't mind.

 ;D
Logged


Want to say thanks?
*************************************
DONATE or check out my WishList
*********************************
Wiziwig
Sr. Member
****
Posts: 407


Programmer and Users Liason and Manager


WWW
Re:[Tested Beta] Bookmarks 1.4.1 and 1.5.0
« Reply #57 on: April 19, 2003, 10:33:21 AM »
Reply with quote

Another bug to report. If admin has enabled bookmarks, and user disables bookmarks in profile, bookmarks show regardless.

Logged

Horseman
YaBB God
*****
Posts: 784


'MAS VALE CABALLO QUE CAUDAL!'


WWW
Re:[Tested Beta] Bookmarks 1.4.1 and 1.5.0
« Reply #58 on: April 19, 2003, 11:02:13 AM »
Reply with quote

this is in subs.php, function bookmarks()

Code: [Select]
<search for>
function yyBookmarks(){
   global $settings, $db_prefix, $ID_MEMBER, $username, $txt, $yytitle, $boardurl, $HTTP_SERVER_VARS, $modSettings;

   $onchange = ' onchange="window.location.href=this.options[this.selectedIndex].value;"';

   if ($username != 'Guest' && $modSettings['showBookmarks'] == '1')
   {
      $sql = "SELECT url, title FROM {$db_prefix}bookmarks WHERE ID_MEMBER = '" . $ID_MEMBER . "' ORDER BY display_order";
      $request = mysql_query ($sql);
      ?>
      <script>
      function addOption(theSel, theText, theValue)
      {
         var newOpt = new Option(theText, theValue);
         var selLength = theSel.length;
         theSel.options[selLength] = newOpt;
      }
      </script>
      <?php
      
echo '<table border=0 cellspacing=0 cellpadding=0><form name="bookmarkFrm"><tbody><tr><td><b>' $txt['bookmarks1'] . '</b> <select name="bookmarks"'.$onchange.'>';

      while (
$row mysql_fetch_assoc($request))
         echo 
'<option value="' $row['url'] . '">' $row['title'] . '</option>';     

      
$addUrl $boardurl '?action=bookmarks;sub=add;title=' urlencode($yytitle) . ';url=' urlencode(urlencode($boardurl.'?'.$HTTP_SERVER_VARS['QUERY_STRING']));

      echo 
'</select> <input type=button value="' $txt['bookmarks8'] . '" onclick="window.location.href=bookmarks.options[bookmarks.selectedIndex].value;"> <input type=button value="' $txt['bookmarks2'] . '" onclick="window.location.href=\'' $addUrl '\';"> <input type=button value="' $txt['bookmarks3'] . '" onclick="window.open(\'' $boardurl '?action=bookmarks;sub=edit\',\'bookmarks\',\'toolbar=no,location=no,status=no,menubar=no,scrollbars=no,width=500,height=220,resizable=no\');"></td></tr></tbody></form></table>';
  }
}
</
search for>

<
replace>
function 
yyBookmarks(){
  global 
$settings$db_prefix$ID_MEMBER$username$txt$yytitle$scripturl$HTTP_SERVER_VARS$modSettings;

  
$onchange ' onchange="window.location.href=this.options[this.selectedIndex].value;"';

   if (
$username != 'Guest' && $modSettings['showBookmarks'] == '1')
   {
   
$request mysql_query("
      SELECT ID_MEMBER, showBookmarks
      FROM 
{$db_prefix}members
      WHERE ID_MEMBER='
$ID_MEMBER'") or database_error(__FILE____LINE__);
      
$memsettings mysql_fetch_array($request);

      if (
$memsettings['showBookmarks'] == '1')
      {
         
$sql "SELECT url, title FROM {$db_prefix}bookmarks WHERE ID_MEMBER = '" $ID_MEMBER "' ORDER BY display_order";
         
$request mysql_query ($sql);
         
?>

               <script>
               function addOption(theSel, theText, theValue)
         {
            var newOpt = new Option(theText, theValue);
            var selLength = theSel.length;
            theSel.options[selLength] = newOpt;
         }  
         </script>
         <?php
         
echo '<table border=0 cellspacing=0 cellpadding=0><form name="bookmarkFrm"><tbody><tr><td><b>' $txt['bookmarks1'] . '</b> <select name="bookmarks"'.$onchange.'>';
         while (
$row mysql_fetch_assoc($request))
         echo 
'<option value="' $row['url'] . '">' $row['title'] . '</option>';   
         
$addUrl $boardurl '?action=bookmarks;sub=add;title=' urlencode($yytitle) . ';url=' urlencode(urlencode($boardurl.'?'.$HTTP_SERVER_VARS['QUERY_STRING']));
         echo 
'</select> <input type=button value="' $txt['bookmarks8'] . '" onclick="window.location.href=bookmarks.options[bookmarks.selectedIndex].value;"> <input type=button value="' $txt['bookmarks2'] . '" onclick="window.location.href=\'' $addUrl '\';"> <input type=button value="' $txt['bookmarks3'] . '" onclick="window.open(\'' $boardurl '?action=bookmarks;sub=edit\',\'bookmarks\',\'toolbar=no,location=no,status=no,menubar=no,scrollbars=no,width=500,height=220,resizable=no\');"></td></tr></tbody></form></table>';
      }
   }   
}
</
replace>
Logged
Nemesis
What's an Admin?
Global Moderator
YaBB God
*****
Posts: 2199



WWW
Re:[Tested Beta] Bookmarks 1.4.1 and 1.5.0
« Reply #59 on: April 19, 2003, 11:05:51 AM »
Reply with quote

Or just download the file again, i have updated it.

 ;D

Thanks Horseman!
Logged


Want to say thanks?
*************************************
DONATE or check out my WishList
*********************************
Pages: 1 2 3 [4] 5 6 Reply Ignore Print 
YaBB SE Community  |  Development  |  Completed mods  |  Topic: [Tested BETA] Bookmarks 1.4.1 and 1.5.0 « previous next »
 


Powered by MySQL Powered by PHP YaBB SE Community | Powered by YaBB SE
2001-2003, YaBB SE Dev Team. All Rights Reserved.
SMF 2.0.18 | SMF © 2021, Simple Machines
Valid XHTML 1.0! Valid CSS!
Page created in 0.131 seconds with 19 queries.