[Beta 1.5.1] AdvIM

[Gobalopper]

Try downloading it again CrazyC, I made a fix shortly after I posted it to fix those typos you mentioned and a couple others I think. Sorry forgot to post about it.

[CrazyC]

Hmm, a couple more problems, but I didn't find fixes for these yet.

When viewing the inbox, outbox or backup box, the to or from username is not displayed, the table cell is just blank.  (don't know how I overlooked that earilier)

And when you viewing a post itself, the delete button doesn't work.  Delete will work from the inbox, outbox or backup box with the fix I posted though.

[Gobalopper]

Is that before or after downloading the new file?

[CrazyC]

Is that before or after downloading the new file?

Well.. if you look at the time of my post and your post, we were posting at the exact same time. (We couldn't have planned that if we tried)  I didn't even see your post about updating the file until just now.  I will download it again now and let you know.

[CrazyC]

Umm, I hate to tell you this, but all the problems that I posted about are still there.

[Gobalopper]

Are you sure? I checked again and those lines were changed. I took my copy of the file and re-uploaded again, let me know if it still isn't working.

[CrazyC]

Are you sure? I checked again and those lines were changed. I took my copy of the file and re-uploaded again, let me know if it still isn't working.

Last night when I re-download the .zip file, I did double check the file dates and times.  All files had the same timestamp as the package I downloaded yesterday morning and all of the problems did still exist.

I just tried it again now and the most everything works, except for there still isn't a from or to username displayed when viewing the inbox, outbox or backup box and the delete button, when viewing an individual message does not work.

If I look at the code again and figure out what the problems could, be I'll let you know.

I really like the changes with this mod, but those few problems still need fixing.  Maybe somehow you still managed to upload something wrong.  I did notice what time you posted that last message.  I know I have missed things or messed things up when I work on coding too late.  hehe

[CrazyC]

I've been playing with the code a little bit, but can't quite seem to figure out what is wrong with the 2 things I mentioned.

In the IMView function, it does seem to be a problem with a button that uses the java DoConfirm though.  If viewing a message in the Inbox, the backup button doesn't work correctly either (DoConfirm again).  I did compare the code that you put in with the original InstantMessage.php file and those lines seem to have almost identical code, with your variable changes.  I don't know enough about javascript though to know if that has something to do with it or not.

I did notice that in the inbox, outbox and backupbox, in the IMIndex function, you are echoing $musername for the variable to the to/from column (depending which box is being viewed) and I don't see anywhere that you set that variable to equal a variable from the sql query.

Hopefully this info will help narrow something down for you.  Then again, maybe it's just something on my end, buy I did try this on both a test site and my normal site.  I supposed I should also mention that I am using PfaBB to, but everything that I have looked at would indicate that PfaBB does NOT interfere with any of the IM code at all.

[mephisto_kur]

I can confirm that these issues are NOT PfaBB related.  I applied the mod to a fresh YaBBSE 1.5.2 install, and everything CrazyC has stated is also a problem with my test site.

I would like to add that sending a message to the BackupBox *deletes* the message.

[CrazyC]

Hopefully you didn't already read these messages and start troubleshooting.  For some reason, I just have to keep playing with this to get it working.....

I've found the fix for the missing username and also discovered that there should have been a couple of if statements when the table column titles are being echoed, depending on which box is presently being viewed.  But, I did not figure out those button problems.  I'll let you mess with that one.

I didn't notice that adding a message to the backup box deletes a message, but I'm not sure if I re-tested that one with your updated file.

Here's what I did:  (you may find a better way)

Added username variable in IMIndex() right after:

Code Select Expand

      $mydate = timeformat($row['msgtime']);

of:

Code Select Expand

   $musername = $row['realName'];


To correct the column labels....
Original code:

Code Select Expand

   <td class="titlebg" bgcolor="' . $color['titlebg'] . '"><b>' . $txt[318] . '</b> (<a href="' . $scripturl . '?action=' . $action . ';orderBy=realName;sort=DESC"><img src="' . $imagesdir . '/arrow_down.gif" border="0" /></a><a href="' . $scripturl . '?action=' . $action . ';orderBy=realName;sort=ASC"><img src="' . $imagesdir . '/arrow_up.gif" border="0" /></a>)</td>'; }

Replaced with:

Code Select Expand

      <td class="titlebg" bgcolor="' . $color['titlebg'] . '" align="center" width="1%"><input type="checkbox" name="allbox" onclick="selectall()" /></td>';
 if ($caller == 1) {
   echo '<td class="titlebg" bgcolor="' . $color['titlebg'] . '"><b>' . $txt[318] . '</b> (<a href="' . $scripturl . '?action=' . $action . ';orderBy=realName;sort=DESC"><img src="' . $imagesdir . '/arrow_down.gif" border="0" /></a><a href="' . $scripturl . '?action=' . $action . ';orderBy=realName;sort=ASC"><img src="' . $imagesdir . '/arrow_up.gif" border="0" /></a>)</td>'; }
 if ($caller == 2) {
   echo '<td class="titlebg" bgcolor="' . $color['titlebg'] . '"><b>' . $txt[324] . '</b> (<a href="' . $scripturl . '?action=' . $action . ';orderBy=realName;sort=DESC"><img src="' . $imagesdir . '/arrow_down.gif" border="0" /></a><a href="' . $scripturl . '?action=' . $action . ';orderBy=realName;sort=ASC"><img src="' . $imagesdir . '/arrow_up.gif" border="0" /></a>)</td>'; }
 if ($caller == 3) {
   echo '<td class="titlebg" bgcolor="' . $color['titlebg'] . '"><b>' . $txt[324] . '/' . $txt[318] . '</b> (<a href="' . $scripturl . '?action=' . $action . ';orderBy=realName;sort=DESC"><img src="' . $imagesdir . '/arrow_down.gif" border="0" /></a><a href="' . $scripturl . '?action=' . $action . ';orderBy=realName;sort=ASC"><img src="' . $imagesdir . '/arrow_up.gif" border="0" /></a>)</td>'; }
 echo '


I hope this is helping and not making things more difficult.

[Gobalopper]

If you are having the delete problem make sure the javascript advim.js file is in the right place. That seems to be the cause of the problem.

I forgot about the columns, I remember thinking to myself I had to fix that.

Just uploaded a new version that remedies those two problems you mentioned. And let me know about the javascript issue for the third problem.

[CrazyC]

If you are having the delete problem make sure the javascript advim.js file is in the right place. That seems to be the cause of the problem.

I did have it in the right place on my test site, but not my regular site.  It didn't make any difference though.  Some weird is going on there.

[mephisto_kur]

With the new file, I get this:

The requested URL /yabbse152/index.php;action=imsend2 was not found on this server.

[mephisto_kur]

Line 439, this:

Code Select Expand


<form action="' . $scripturl . ';action=imsend2"


needs changed to this:

Code Select Expand


<form action="' . $scripturl . '?action=imsend2"


[mephisto_kur]

The delete instead of backup was my fault.  I typoed the path to the advim.js file.